Issue Details (XML | Word | Printable)

Key: MDL-20303
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Marsden
Reporter: Sara Arjona
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Contacts are'nt showed in private messages window

Created: 16/Sep/09 08:23 PM   Updated: 17/Sep/09 06:31 AM
Component/s: Messages
Affects Version/s: 1.9.5
Fix Version/s: None

Environment: Solaris + Oracle

Database: Oracle
URL: http://agora.xtec.cat
Participants: Dan Marsden and Sara Arjona
Security Level: None
Difficulty: Easy
Resolved date: 17/Sep/09
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Contacts list isn't showed in messages window. When debug is activated the following error appears:

ORA-00911: invalid character

SELECT u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.lastaccess, count(m.id) as messagecount FROM mlmessage_contacts mc JOIN mluser u ON u.id = mc.contactid LEFT OUTER JOIN mlmessage m ON m.useridfrom = mc.contactid AND m.useridto = 85 WHERE mc.userid = 85 AND mc.blocked = 0 GROUP BY u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.lastaccess ORDER BY u.firstname ASC;

  • line 686 of lib/dmllib.php: call to debugging()
  • line 56 of message/lib.php: call to get_recordset_sql()
  • line 87 of message/index.php: call to message_print_contacts()

ORA-00911: invalid character

SELECT u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.lastaccess, count(m.id) as messagecount FROM mlmessage m JOIN mluser u ON u.id = m.useridfrom LEFT OUTER JOIN mlmessage_contacts mc ON mc.contactid = m.useridfrom AND mc.userid = m.useridto WHERE mc.id IS NULL AND m.useridto = 85 GROUP BY u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.lastaccess ORDER BY u.firstname ASC;

  • line 686 of lib/dmllib.php: call to debugging()
  • line 88 of message/lib.php: call to get_recordset_sql()
  • line 87 of message/index.php: call to message_print_contacts()

To solve it it's necessary to delete the semicolon at the end of the following SQL sentences in the message/lib.php file:

message/lib.php (line 52)
$contactsql = "SELECT u.id, u.firstname, u.lastname, u.picture,
u.imagealt, u.lastaccess, count(m.id) as messagecount
FROM {$CFG->prefix}message_contacts mc
JOIN {$CFG->prefix}user u
ON u.id = mc.contactid
LEFT OUTER JOIN {$CFG->prefix}message m
ON m.useridfrom = mc.contactid
AND m.useridto = {$USER->id}
WHERE mc.userid = {$USER->id}
AND mc.blocked = 0
GROUP BY u.id, u.firstname, u.lastname, u.picture,
u.imagealt, u.lastaccess
ORDER BY u.firstname ASC";

message/lib.php (line 83)
$strangersql = "SELECT u.id, u.firstname, u.lastname, u.picture,
u.imagealt, u.lastaccess, count(m.id) as messagecount
FROM {$CFG->prefix}message m
JOIN {$CFG->prefix}user u
ON u.id = m.useridfrom
LEFT OUTER JOIN {$CFG->prefix}message_contacts mc
ON mc.contactid = m.useridfrom AND
mc.userid = m.useridto
WHERE mc.id IS NULL AND m.useridto = {$USER->id}
GROUP BY u.id, u.firstname, u.lastname, u.picture,
u.imagealt, u.lastaccess
ORDER BY u.firstname ASC";



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Marsden added a comment - 17/Sep/09 06:31 AM
thanks for the great bug report - this is now fixed in 1.9Stable and HEAD