Moodle

<span class="label "> breaks validation in course home page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.5
  • Fix Version/s: None
  • Component/s: Accessibility
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE

Description

When adding label in courses home page and formatting labels content with the editor, using XHTML valid tags such as h1, hr, p, etc breaks validation since they are inside a "span" tag. This makes almost impossible to create labels with both good format and valid XHTML, thus breaking accessibility.

Possible workaround:

  • change the span tag with div.

Issue Links

This issue will help resolve:
MDL-19653 XHTML 1.0 Validation Error activity label <span class="label"> Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Bicciolo added a comment -

Adding Eloy as watcher for commenting and triaging this issue.

Andrea

Show
Andrea Bicciolo added a comment - Adding Eloy as watcher for commenting and triaging this issue. Andrea
Hide
Permalink
Petr Škoda (skodak) added a comment -

Fixed, thanks!

Petr Skoda

Show
Petr Škoda (skodak) added a comment - Fixed, thanks! Petr Skoda
Hide
Permalink
Matthew Davidson added a comment -

divs are block level elements. If you wish to use divs instead of spans you must give it the style property of display:inline. Otherwise when you try to indent the label nothing will happen. divs create a breakline and spans don't, so when you move right it adds a spacer image. Spans don't start on a new line, but div's do

Show
Matthew Davidson added a comment - divs are block level elements. If you wish to use divs instead of spans you must give it the style property of display:inline. Otherwise when you try to indent the label nothing will happen. divs create a breakline and spans don't, so when you move right it adds a spacer image. Spans don't start on a new line, but div's do
Hide
Permalink
Matthew Davidson added a comment -

this fix breaks indent for labels

Show
Matthew Davidson added a comment - this fix breaks indent for labels
Hide
Permalink
Petr Škoda (skodak) added a comment -

This span was already changed to div in 2.0dev, I suppose we need to fix it there too.

Show
Petr Škoda (skodak) added a comment - This span was already changed to div in 2.0dev, I suppose we need to fix it there too.
Hide
Permalink
Matthew Davidson added a comment -

is there a reason you didn't leave it as a div and just add display:inline to the label class stylesheet?

Show
Matthew Davidson added a comment - is there a reason you didn't leave it as a div and just add display:inline to the label class stylesheet?
Hide
Permalink
Matthew Davidson added a comment -

sorry, that came off wrong. Just wanted to know if adding display:inline to that class would fix both problems

Show
Matthew Davidson added a comment - sorry, that came off wrong. Just wanted to know if adding display:inline to that class would fix both problems
Hide
Permalink
Petr Škoda (skodak) added a comment -

This reason is I did not have time to test it yet, sorry.

Show
Petr Škoda (skodak) added a comment - This reason is I did not have time to test it yet, sorry.
Hide
Permalink
Matthew Davidson added a comment -

ah, I see...sorry

Show
Matthew Davidson added a comment - ah, I see...sorry
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (1)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.