Moodle

RSS Unit tests failing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: RSS
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

There was a fatal error if $this->assertTrue($itemone = $feed->get_item(0)); failed, which it did, the next assert blew up. I have committed an iterim fix for that.

However, there are many failures:

Moodle unit tests: lib/simpletest/testrss.php
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Expected false, got [String: cURL Error: couldn't connect to host] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 39]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: Moodle News] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 41]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: http://moodle.org/mod/forum/view.php?f=1] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 43]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: General news about Moodle. Moodle is a leading open-source course management system (CMS) - a software package designed to help educators create quality online courses. Such e-learning systems are so...] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 44]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match String: © 2007 moodle at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 46]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: http://moodle.org/pix/i/rsssitelogo.gif] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 47]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: moodle] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 48]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: http://moodle.org] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 49]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: 140] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 50]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails as [NULL] does not match [String: 35] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 51]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 53]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
Equal expectation fails because [Integer: 0] differs from [Integer: 15] by 15 at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 54]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_getfeed
at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 56]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_redirect
Expected false, got [String: cURL Error: couldn't connect to host] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 120]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_redirect
Equal expectation fails as [NULL] does not match [String: Moodle News] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 121]
Fail: lib/simpletest/testrss.php / ? moodlesimplepie_test / ? test_redirect
Equal expectation fails as [NULL] does not match [String: http://moodle.org/mod/forum/view.php?f=1] at [/fs2/www/html/tjh238/moodle_head/lib/simpletest/testrss.php line 122]
1/1 test cases complete: 4 passes, 16 fails and 0 exceptions.

Activity

Hide
Dan Poltawski added a comment -

Hi Tim,

Sorry for delay in commenting on this... The tests depend on working http networking. I see you've put in a fix which makes this clearer when tests are failing due to network configuration.

Do you think this is adequate enough to close this bug?

Show
Dan Poltawski added a comment - Hi Tim, Sorry for delay in commenting on this... The tests depend on working http networking. I see you've put in a fix which makes this clearer when tests are failing due to network configuration. Do you think this is adequate enough to close this bug?
Hide
Tim Hunt added a comment -

I guess what I did is good enough. Resolving.

Show
Tim Hunt added a comment - I guess what I did is good enough. Resolving.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: