[#MDL-20398] Unit tests give spurious exceptions when $CFG->debugdisplay is false. - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0
Fix Version/s: 2.0
Component/s: Unit tests
Labels:
None

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

The problem is that when $CFG->debugdisplay is false, debugging calls trigger_error. The unit test framework reports all calls to trigger_error as exceptions.

Activity

Hide

Permalink

Tim Hunt added a comment - 01/Oct/09 2:07 AM

The best solution I can see is to display all debugging messages on-screen during unit testing.

The only alternative would be to ignore debugging messages completely during unit tests when $CFG->debugdisplay is false, and that seems like a worse option.

Fix checked in, with a comment pointing to this bug.

Show

Tim Hunt added a comment - 01/Oct/09 2:07 AM The best solution I can see is to display all debugging messages on-screen during unit testing. The only alternative would be to ignore debugging messages completely during unit tests when $CFG->debugdisplay is false, and that seems like a worse option. Fix checked in, with a comment pointing to this bug.

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Tester:

Nobody

Participants:

Tim Hunt

Vote (0)

Watch (1)

Dates

Created:

01/Oct/09 2:03 AM

Updated:

13/Dec/10 6:39 PM

Resolved:

01/Oct/09 2:07 AM