Moodle

(Bad) duplication of code between output of normal grader report and the "Fixed Student Column" version

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Currently there is a great amount of badly duplicated code between the original grader report and its newer fixed students version. The visual improvements (CSS classes etc.) given to the newer version have not been copied over to the older view, which now suffers from inconsistent and broken CSS rules.

Solution: refactor the duplicated parts to bring consistency and maintainability to these two different versions of the report

Activity

Hide
Permalink
Nicolas Connault added a comment -

Refactoring complete. The entire table(s) is/are generated through the new OUTPUT libs, and there is no more duplication of code

Show
Nicolas Connault added a comment - Refactoring complete. The entire table(s) is/are generated through the new OUTPUT libs, and there is no more duplication of code

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.