Moodle

get_my_courses does not properly obey the limit parameter

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.6
  • Component/s: Course, Libraries, My Moodle
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

get_my_courses always returns 2 more courses than specified in $limit (if available).

This is because of the way that it applied the limit.

It does it using a counter as it steps through the courses. In this process, there are two off by one error.

I have attached a diff that simplifies it somewhat (to read), and removes the two off by one errors.

Attachments

  1. File
    accesslib.diff
    08/Oct/09 12:45 AM
    0.5 kB
    Eric Merrill
  2. File
    datalib.diff
    08/Oct/09 12:38 AM
    0.5 kB
    Eric Merrill

Issue Links

This issue will help resolve:
MDL-19089 Ellipses incorrectly displayed for My Moodle page Minor Closed
MDL-13224 number of courses in MyMoodle home page Minor Reopened

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eric Merrill added a comment -

get_user_courses_bycap appears to suffer by the same off by 2 problem. Attaching patch for accesslib.

Show
Eric Merrill added a comment - get_user_courses_bycap appears to suffer by the same off by 2 problem. Attaching patch for accesslib.
Hide
Permalink
Martin Dougiamas added a comment -

Good catch! +1 from me! Thanks!

Show
Martin Dougiamas added a comment - Good catch! +1 from me! Thanks!
Hide
Permalink
Eric Merrill added a comment -

I have committed the changes to get_user_courses_bycap and get_my_courses to 19_STABLE and HEAD - Resolving ticket.

Show
Eric Merrill added a comment - I have committed the changes to get_user_courses_bycap and get_my_courses to 19_STABLE and HEAD - Resolving ticket.
Hide
Permalink
Andrew Davis added a comment -

Looks good. Closing.

Show
Andrew Davis added a comment - Looks good. Closing.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.