Issue Details (XML | Word | Printable)

Key: MDL-20564
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Dan Poltawski
Reporter: Valery Fremaux
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Internationalization bug in block rss_client

Created: 15/Oct/09 05:48 AM   Updated: 15/Oct/09 05:48 AM
Return to search
Component/s: RSS
Affects Version/s: 1.9.5
Fix Version/s: None

Database: Any
Participants: Dan Poltawski and Valery Fremaux
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Double issue on internationalization :

prefered title is not internationalized :

block_rss_client.php §38 is :

            $this->title = $this->config->title;

Should be :

            $this->title = format_string($this->config->title);

As a direct consequence, config_instance.html widget for preferred title is not quote protected at §123 and shows :

            $this->title = $this->config->title;

Should be :

            $this->title = htmlspecialchars($this->config->title, ENT_QUOTES, 'UTF-8');

Cheers.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
No commits have yet been performed on this issue.