Moodle

import latest Zend framework 1.9.4

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Web Services
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

switch keyword to -ko too

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

done

Show
Petr Škoda (skodak) added a comment - done
Hide
Permalink
Eloy Lafuente (stronk7) added a comment - - edited

Wow, the whole framework? Do we need it entirely?

31MB for "Implement basic web service function set (MDL-12886)" ?!?!?

-10^6 (at least) here. Ciao

Show
Eloy Lafuente (stronk7) added a comment - - edited Wow, the whole framework? Do we need it entirely? 31MB for "Implement basic web service function set (MDL-12886)" ?!?!? -10^6 (at least) here. Ciao
Hide
Permalink
Petr Škoda (skodak) added a comment -

Hmmm, yes I noticed that too, but it was not my idea to import this library. I tried the reduce the size too, but libs in Zend framework are linked together, it is not easy and would have to be done every time we upgrade.

After spending a few days writing code that uses the XML-RPC and SOAP server code I think it would be easier to just take bits of their BSD code and write our own servers, in the end it is just a wrapper (sometimes incomplete or even buggy) around the native PHP extensions.

If you decide to start pruning the framework please consider putting it in some different directory, not lib/zend/ which imo indicates it contains the complete framework (some other parts of moodle might want to use it too).

My -10 to use zend library too

Petr

PS: adding missing import notes

Show
Petr Škoda (skodak) added a comment - Hmmm, yes I noticed that too, but it was not my idea to import this library. I tried the reduce the size too, but libs in Zend framework are linked together, it is not easy and would have to be done every time we upgrade. After spending a few days writing code that uses the XML-RPC and SOAP server code I think it would be easier to just take bits of their BSD code and write our own servers, in the end it is just a wrapper (sometimes incomplete or even buggy) around the native PHP extensions. If you decide to start pruning the framework please consider putting it in some different directory, not lib/zend/ which imo indicates it contains the complete framework (some other parts of moodle might want to use it too). My -10 to use zend library too Petr PS: adding missing import notes

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.