[#MDL-20700] use new coding style - no id cvs tags and no closing php tags in files

Issue Details (XML | Word | Printable)

Key:	MDL-20700
Type:	Task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

use new coding style - no id cvs tags and no closing php tags in files

Created: 01/Nov/09 06:20 PM Updated: 05/Nov/09 04:27 AM

Component/s:

General

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Petr Skoda
Security Level:	None
Resolved date:	05/Nov/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

1/ Long ago it was decided (vote on moodle.org) we are going to stop using $Id:$ because it breaks badly in git.
2/ PHP works much better when there is no ?> tag because there can not be any trailing whitespace problems

The 1.9 and HEAD diverged a lot already, we are not expecting any more significant merging from STABLE, now is the time these changes all over the place ;-)

(This would not be possible to do after the next branching in HEAD.)

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Nov/09 06:31 PM

coding style guide in docs updated

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Nov/09 09:03 PM - edited

leaving out for now:

/course/ - sam has some pending patches there
/user/ - sam's patches
/question/ and quiz - Tim's area

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Nov/09 09:16 PM

Omitting /backup/ too - there seems to be a lot of incorrect whitespace there in latest CC commit

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Nov/09 09:18 PM

/lang/ is also separate problem

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Nov/09 09:19 PM

/theme/ to be done later together with major refactoring there

[ Permalink | « Hide ]

Petr Skoda added a comment - 04/Nov/09 04:21 PM

Lat pending areas are:

questions
mod/quiz
mod/wiki (will be replaced by new code completely)

Going to ask Tim today and finish asap

[ Permalink | « Hide ]

Petr Skoda added a comment - 04/Nov/09 04:22 PM

oh, forgot to mention that I was gradually converting all 3rd party libs to use "-ko" keyword expansion - that should keep them in sync with upstream (seems to work fine so far)

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Nov/09 04:26 AM

done, the $ID: tags were left in lang packs and some 3rd party libraries - "-ko" changes in lib would affect 1.9 too, lang packs will be fixed later

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Nov/09 04:27 AM

thanks everybody for your patience and support, sorry for any problems caused

All content on this web site is made available under the GNU General Public License, unless otherwise stated.