Moodle

use new coding style - no id cvs tags and no closing php tags in files

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: General
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

1/ Long ago it was decided (vote on moodle.org) we are going to stop using $Id:$ because it breaks badly in git.
2/ PHP works much better when there is no ?> tag because there can not be any trailing whitespace problems

The 1.9 and HEAD diverged a lot already, we are not expecting any more significant merging from STABLE, now is the time these changes all over the place

(This would not be possible to do after the next branching in HEAD.)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

coding style guide in docs updated

Show
Petr Škoda (skodak) added a comment - coding style guide in docs updated
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

leaving out for now:

  • /course/ - sam has some pending patches there
  • /user/ - sam's patches
  • /question/ and quiz - Tim's area
Show
Petr Škoda (skodak) added a comment - - edited leaving out for now:
  • /course/ - sam has some pending patches there
  • /user/ - sam's patches
  • /question/ and quiz - Tim's area
Hide
Permalink
Petr Škoda (skodak) added a comment -

Omitting /backup/ too - there seems to be a lot of incorrect whitespace there in latest CC commit

Show
Petr Škoda (skodak) added a comment - Omitting /backup/ too - there seems to be a lot of incorrect whitespace there in latest CC commit
Hide
Permalink
Petr Škoda (skodak) added a comment -

/lang/ is also separate problem

Show
Petr Škoda (skodak) added a comment - /lang/ is also separate problem
Hide
Permalink
Petr Škoda (skodak) added a comment -

/theme/ to be done later together with major refactoring there

Show
Petr Škoda (skodak) added a comment - /theme/ to be done later together with major refactoring there
Hide
Permalink
Petr Škoda (skodak) added a comment -

Lat pending areas are:

  • questions
  • mod/quiz
  • mod/wiki (will be replaced by new code completely)

Going to ask Tim today and finish asap

Show
Petr Škoda (skodak) added a comment - Lat pending areas are:
  • questions
  • mod/quiz
  • mod/wiki (will be replaced by new code completely)
Going to ask Tim today and finish asap
Hide
Permalink
Petr Škoda (skodak) added a comment -

oh, forgot to mention that I was gradually converting all 3rd party libs to use "-ko" keyword expansion - that should keep them in sync with upstream (seems to work fine so far)

Show
Petr Škoda (skodak) added a comment - oh, forgot to mention that I was gradually converting all 3rd party libs to use "-ko" keyword expansion - that should keep them in sync with upstream (seems to work fine so far)
Hide
Permalink
Petr Škoda (skodak) added a comment -

done, the $ID: tags were left in lang packs and some 3rd party libraries - "-ko" changes in lib would affect 1.9 too, lang packs will be fixed later

Show
Petr Škoda (skodak) added a comment - done, the $ID: tags were left in lang packs and some 3rd party libraries - "-ko" changes in lib would affect 1.9 too, lang packs will be fixed later
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks everybody for your patience and support, sorry for any problems caused

Show
Petr Škoda (skodak) added a comment - thanks everybody for your patience and support, sorry for any problems caused

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.