Issue Details (XML | Word | Printable)

Key: MDL-20715
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Use of undefined constant OCI_COMMIT_ON_SUCCESS

Created: 02/Nov/09 10:29 PM   Updated: 02/Nov/09 10:43 PM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 02/Nov/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Fresh HEAD install:
Notice: Use of undefined constant OCI_COMMIT_ON_SUCCESS - assumed 'OCI_COMMIT_ON_SUCCESS' in /home/mudrd8mz/public_html/moodle/lib/dml/moodle_database.php on line 167

solution: we need to move the default value assignment into the connect() method

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 1 file to 'Moodle CVS' - 02/Nov/09 10:33 PM
MDL-20715 fixed notice from dml native oci driver when php driver not installed
MODIFY lib/dml/oci_native_moodle_database.php   Rev. 1.30    (+7 -2 lines)
Petr Skoda made changes - 02/Nov/09 10:34 PM
Field Original Value New Value
QA Assignee stronk7
Petr Skoda added a comment - 02/Nov/09 10:34 PM
should be fixed, please reopen if needed

Petr Skoda made changes - 02/Nov/09 10:34 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) added a comment - 02/Nov/09 10:43 PM
(oracle passign tests after your patch, so if it cleaned the error in your side... perfect!)

Thanks!


Eloy Lafuente (stronk7) made changes - 02/Nov/09 10:43 PM
Status Resolved [ 5 ] Closed [ 6 ]