Details
Bug
Closed
Minor
Description
Create a quiz
Add at least a question (I added only one multiple choice question)
Go to preview the quiz
Push the button "Preview quiz now"
Provide an answer
Push the "Submit all and finish"
Close the java alert message
What I get WITH DEBUGGER = ALL is:
Notice: Undefined variable: ispreviewing in moodle19/mod/quiz/review.php on line 127
Confirmed
it should be $isteacher, calculated on line 41 and already used on these lines
ppollet@prope:~/web/moodle.195/mod/quiz$ grep -Rin isteacher review.php
41: $isteacher = has_capability('mod/quiz:preview', get_context_instance(CONTEXT_MODULE, $cm->id));
43: $popup = $isteacher ? 0 : $quiz->popup; // Controls whether this is shown in a javascript-protected window or with a safe browser.
118: if ($isteacher and $attempt->userid == $USER->id) {
128: if (!$isteacher && $quiz->popup) {
157: if ($isteacher and $attempt->userid == $USER->id) {
169: if (!$isteacher) {
295: $options->history = ($isteacher and !$attempt->preview) ? 'all' : 'graded';
307: if (!$isteacher) {
so
127 //if (!$ispreviewing && $quiz->popup) {
128 if (!$isteacher && $quiz->popup) {
Cheers