Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: None
-
Component/s: Libraries
-
Labels:None
-
Affected Branches:MOODLE_20_STABLE
Description
Currently in HEAD print_scale_menu_helpbutton() & help_button::make_scale_menu() are throwing exceptions.
print_scale_menu_helpbutton() is in deprecated lib and is simply used as follows:
$OUTPUT->help_button(help_button::make_scale_menu($courseid, $scale));
2 immediate problems are
- OUTPUT doesn't have a help_button method.... it should probably be help_icon
- The help_button class doesn't exist... it should probably be moodle_help_icon
However even after those have been corrected you still get mountains of exceptions because of different things not being set on the classes.
I'm not 100% sure but in this case scale menu is a fringe case as it has a special help page (Am I thinking of the right thing here).
I would imagine that the whole implementation of that needs to be re-thought.
Also to whoever takes on this issue, grap for '::make_scale_menu' there are several implementation that need correcting.
Issue Links
| This issue duplicates: | ||||
| MDL-21217 | reimplement $OUTPUT->help_scales() |
|
|
|
This seems to have been fixed by
MDL-21217MDL-21217