Moodle

moodle_database field names do not follow the codeing guidelines

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Trivial Trivial
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

Apologies for being a coding standards nazi, but field names are like variable names, and should look like $lastsql, not $last_sql etc.

http://docs.moodle.org/en/Development:Coding_style#Variables

Since most of these are protected, and the classes have good unit tests, it should be possible to rename them. That way, the nice new Moodle 2.0 code can set a good example for everyone else to follow.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Being an anti-rules guy, lowering this to trivial and not agreeing with that rule at all (readability is, at least for me, clearly better if using $force_rollback than $forcerollback).

Surely it's because I'm not an English guy but I can bet I'll run way more typos in the second form than in the first one.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Being an anti-rules guy, lowering this to trivial and not agreeing with that rule at all (readability is, at least for me, clearly better if using $force_rollback than $forcerollback). Surely it's because I'm not an English guy but I can bet I'll run way more typos in the second form than in the first one. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: