Moodle

remove all legacy themes from HEAD except standard theme

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

I suppose all interested developers already agreed we need to start from scratch. Over the years we have created multiple layers of CSS hacks, unused CSS, IE5.5 compatibility and who knows what else in our themes.

The theme cleanup steps are:
1/ remove old themes except "standard" which will be kept for now, other developers need something that kind of work during the great themes refactoring
2/ new "base" theme will be the parent of all new themes
3/ we will create brand new "newstandard" theme
4/ when "newstandard" is good enough we will delete old standard and rename newstandard to standard
5/ standardwhite|red|blue will be replaced by new "standardcolour" theme with colour related configuration options in admin interface
6/ other themes can be readded when updated

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

I guess this needs to be explained in forums and temporary file theme/missing_themes_readme.txt would help too for now.

Show
Petr Škoda (skodak) added a comment - I guess this needs to be explained in forums and temporary file theme/missing_themes_readme.txt would help too for now.
Hide
Permalink
Tim Hunt added a comment -

Petr,

1. (& 6.) I assume we are keeping customcorners and anomaly - but both brought up to modern standards. Possibly chameleon too. (Possibly get Patrick Malley to work on this.)

2. - 4. Good.

5. Good in principle, but would it be better to base this on anomaly or something nicer than standard?

Show
Tim Hunt added a comment - Petr, 1. (& 6.) I assume we are keeping customcorners and anomaly - but both brought up to modern standards. Possibly chameleon too. (Possibly get Patrick Malley to work on this.) 2. - 4. Good. 5. Good in principle, but would it be better to base this on anomaly or something nicer than standard?
Hide
Permalink
Petr Škoda (skodak) added a comment -

most advanced themes are supposed to be based on "base" theme, not the white standard any more - this is one thing Patrick proposed

Show
Petr Škoda (skodak) added a comment - most advanced themes are supposed to be based on "base" theme, not the white standard any more - this is one thing Patrick proposed
Hide
Permalink
Tim Hunt added a comment -

Surely standard theme === base theme. Perhaps it is worth renaming standard theme.

Show
Tim Hunt added a comment - Surely standard theme === base theme. Perhaps it is worth renaming standard theme.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I decided to keep the old themes there for a while, only some standard colour variants are gone

Show
Petr Škoda (skodak) added a comment - I decided to keep the old themes there for a while, only some standard colour variants are gone
Hide
Permalink
Petr Škoda (skodak) added a comment -

the old themes are causing tons of confusion, I guess we should really remove from cvs for now:

1/ rename standard --> oldstandard
2/ keep only base, oldstandard, experiment and anomaly
3/ fix base while working on experiment and anomaly - this includes solving of navbar future
3/ and new "standard"
4/ remove oldstandard when new "standard" ready
5/ readd other old/new themes

Show
Petr Škoda (skodak) added a comment - the old themes are causing tons of confusion, I guess we should really remove from cvs for now: 1/ rename standard --> oldstandard 2/ keep only base, oldstandard, experiment and anomaly 3/ fix base while working on experiment and anomaly - this includes solving of navbar future 3/ and new "standard" 4/ remove oldstandard when new "standard" ready 5/ readd other old/new themes
Hide
Permalink
Petr Škoda (skodak) added a comment -

removed, I should have done it long ago, it was really confusing for most ppl

Show
Petr Škoda (skodak) added a comment - removed, I should have done it long ago, it was really confusing for most ppl

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.