Moodle

remove renderer that tries to emulate templating system

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Deferred
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

The problems are:

  • it is not what theme designers requested - they wanted templates for thing like login page
  • the renderers api is not stable yet - we can not declare this api public yet

We could reintroduce this later or it is also possible to add it into just one theme.

IMO this is not supportable in the 2.0 and should be removed from HEAD. I would personally prefer if we tried to introduce some sort of real templates in 2.1.

Activity

Hide
Tim Hunt added a comment -

Well, I actually thing this best way would be to have people experiment (ideally with several different approaches) in contrib. That lets them get on with what they want to do, and we can later take the best into core. That is how open source is supposed to work, anyway.

The reason I wanted to make a crude template renderer from the start was as a proof of concept. I wanted it to be possible to write a template renderer, and that puts some constraints on what you can and cannot do in a renderer class. Therefore, I was afraid that if we did not have a template renderer in core (even a crappy one) developers would abuse renderers and it would be impossible to write a template renderer later.

I hope you understand that reasoning. I also understand your reasoning, but I don't know what the best answer is.

Show
Tim Hunt added a comment - Well, I actually thing this best way would be to have people experiment (ideally with several different approaches) in contrib. That lets them get on with what they want to do, and we can later take the best into core. That is how open source is supposed to work, anyway. The reason I wanted to make a crude template renderer from the start was as a proof of concept. I wanted it to be possible to write a template renderer, and that puts some constraints on what you can and cannot do in a renderer class. Therefore, I was afraid that if we did not have a template renderer in core (even a crappy one) developers would abuse renderers and it would be impossible to write a template renderer later. I hope you understand that reasoning. I also understand your reasoning, but I don't know what the best answer is.
Hide
Petr Škoda (skodak) added a comment -

sending file with renderer factory for template emulation

Show
Petr Škoda (skodak) added a comment - sending file with renderer factory for template emulation
Hide
Petr Škoda (skodak) added a comment -

resolving as deferred, can be revisited later when things get more stable in 2.1

Show
Petr Škoda (skodak) added a comment - resolving as deferred, can be revisited later when things get more stable in 2.1

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: