Issue Details (XML | Word | Printable)

Key: MDL-20815
Type: Sub-task Sub-task
Status: Open Open
Priority: Minor Minor
Assignee: Jordi Piguillem Poch
Reporter: Petr Škoda (skodak)
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-20812

Upgrade code from other wikis

Created: 11/Nov/09 06:14 PM   Updated: 15/Nov/09 01:55 AM
Component/s: Wiki (2.x)
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Jordi Piguillem Poch and Petr Škoda (skodak)
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
1/ upgrade_mod_savepoint() not used, it should be in all official 2.0 plugins

2/ $result should be replaced by exceptions

3/ incorrect use of exceptions in many places - creating new general moodle_exception is always the last option, the exception type and details should give you more hints, it is not needed to localise upgrade problems usually

4/ camel case not used in core moodle - NwikiMigrate()

5/ I guess it would be more readable if each wiki had different directory - from my pov the only fully working has to be migration from the official 1.9x wiki

6/ use DML recordsets when working with lots of data!

7/ migration from ewiki not implemented yet, right?



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
There are no comments yet on this issue.