Moodle

$OUTPUT->has_navbar is evil and should be destroyed

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Renderers must only generate HTML. has_navbar is logic, and, presumably, belong somewhere else like $PAGE.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for picking that one up Tim, I'm always happy to crush the evil
I've moved has_navbar to PAGE which certainly makes more sense and converted the standard templates. I'll keep an eye out for it again in Petr's new themes code encase it gets missed out.
Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks for picking that one up Tim, I'm always happy to crush the evil I've moved has_navbar to PAGE which certainly makes more sense and converted the standard templates. I'll keep an eye out for it again in Petr's new themes code encase it gets missed out. Cheers Sam
Hide
Permalink
Andrew Davis added a comment -

The evil has been purged. Closing issue.

Show
Andrew Davis added a comment - The evil has been purged. Closing issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.