Moodle

obsolete use of mdl_user_teachers in SQL query

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Wiki (2.x)
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE

Description

when selecting use "separate groups" in module's settings
an error/warning is displayed on the footer of the editing page:
"use of obsolete tables in sqt query..."

it is related to the fact that on get_course_teachers() in mod/wiki/db/moodle/wiki_presistor.php line 833
the sql query uses mdl_user_teachers which is not in the database anymore (version 1.9.2 + )

since, there is a built-in get_course_teachers() which already works fine. i used that instead.

i changed line 538 on mod/wiki/lib.php from :
$listteachers = $wikimanager->get_course_teachers($COURSE->id);
to:
$listteachers = get_course_teachers($COURSE->id);

Activity

Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.
Hide
Nadav Kavalerchik added a comment -

It should be move to CONTRIB since it is related to NWiki module for Moodle 1.9
And, the suggested fix solves this issue.

Show
Nadav Kavalerchik added a comment - It should be move to CONTRIB since it is related to NWiki module for Moodle 1.9 And, the suggested fix solves this issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: