Moodle

Title attribute missing from cells on grader report

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

The title attribute of the cells of the table on the grader report are used to create tooltips. The title attribute appears to be missing in 2.0
It should contain something like this.
<div class="fullname">sam student</div><div class="itemname">test quiz</div>

Attachments

  1. Text File
    grader.patch
    11/Dec/09 11:10 AM
    1.0 kB
    Andrew Davis
  2. Text File
    outputrenderers.patch
    11/Dec/09 11:10 AM
    0.9 kB
    Andrew Davis

Issue Links

This issue will be resolved by:
MDL-21535 convert/review and test all JS in gradebook Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Davis added a comment -

This solution has two halves. Firstly the output renderer method table() wasn't including the title attribute on table cells. Secondly, some Javascript preceding the setup of the tooltips was silently failing.

I've attached patches for review.

Show
Andrew Davis added a comment - This solution has two halves. Firstly the output renderer method table() wasn't including the title attribute on table cells. Secondly, some Javascript preceding the setup of the tooltips was silently failing. I've attached patches for review.
Hide
Permalink
Andrew Davis added a comment -

Committed.

Show
Andrew Davis added a comment - Committed.
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening, we should not do changes that might introduce XSS in apis like tables, the problem is if somebody cleans the title and the framework then decodes the text some nasty chars may appear.

Show
Petr Škoda (skodak) added a comment - reopening, we should not do changes that might introduce XSS in apis like tables, the problem is if somebody cleans the title and the framework then decodes the text some nasty chars may appear.
Hide
Permalink
Petr Škoda (skodak) added a comment -

why did you need the html_entity_decode() there?

Show
Petr Škoda (skodak) added a comment - why did you need the html_entity_decode() there?
Hide
Permalink
Petr Škoda (skodak) added a comment -

commits in MDL-20945

Show
Petr Škoda (skodak) added a comment - commits in MDL-20945
Hide
Permalink
Andrew Davis added a comment -

I'm not actually sure why the html_entity_decode() is there right now. I made those changes days ago but the grader report appears to have been broken by the themes changes committed this morning.

The cell titles are constructed at grade/report/grader/lib.php line 851 if that's helpful.

Show
Andrew Davis added a comment - I'm not actually sure why the html_entity_decode() is there right now. I made those changes days ago but the grader report appears to have been broken by the themes changes committed this morning. The cell titles are constructed at grade/report/grader/lib.php line 851 if that's helpful.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I have removed the entity decoding for now, will have a look at that later when working on JS YUI3 migration, thanks

Show
Petr Škoda (skodak) added a comment - I have removed the entity decoding for now, will have a look at that later when working on JS YUI3 migration, thanks
Hide
Permalink
Andrew Davis added a comment -

Assigning to Sam as he's doing the YUI 3 migration.

Show
Andrew Davis added a comment - Assigning to Sam as he's doing the YUI 3 migration.
Hide
Permalink
Sam Hemelryk added a comment -

Will be resolved by MDL-21535 while looking at reviewing + converting all gradebook JS

Show
Sam Hemelryk added a comment - Will be resolved by MDL-21535 while looking at reviewing + converting all gradebook JS

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.