Moodle

Invalid HTML in the grader report

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.7
  • Fix Version/s: 1.9.8
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The <th> for the link to the user report is included inside the <th> for the username, which means that the columns do not line up.

Also, It is hard-coded to use the user report, rather than respecting the $CFG->grade_profilereport setting.

The attached patch fixes both of these.

Issue Links

This issue has been marked as being related by:
MDL-21374 column averages are in the wrong position in the grader report Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

The bad HTML came from MDL-12972.

Show
Tim Hunt added a comment - The bad HTML came from MDL-12972.
Hide
Permalink
Tim Hunt added a comment -

OK, fix checked in.

Show
Tim Hunt added a comment - OK, fix checked in.
Hide
Permalink
Andrew Davis added a comment -

Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?

Show
Andrew Davis added a comment - Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?
Hide
Permalink
Andrew Davis added a comment -

see my previous comment.

Show
Andrew Davis added a comment - see my previous comment.
Hide
Permalink
Tim Hunt added a comment -

Thank you for QAing this property. I should have checked more carefully. Please commit these changes.

Show
Tim Hunt added a comment - Thank you for QAing this property. I should have checked more carefully. Please commit these changes.
Hide
Permalink
Andrew Davis added a comment -

committed. marking as resolved.

Show
Andrew Davis added a comment - committed. marking as resolved.
Hide
Permalink
David Mudrak added a comment -

Reviewed the commit. Closing.

Show
David Mudrak added a comment - Reviewed the commit. Closing.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.