Moodle

Remove update module buttons from header once all modules extend settings block

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

As requested by Martin.
The update this module button displayed in the header of the page should be removed once the module extends the settings block.
There should always be a update this module link in the settings block.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Complete. The following are the only remaining uses of update_module_button in core:

  • mod/wiki module - It's getting a refactor
  • mod/resource module - Legacy
  • lib/pagelib - The page_generic_activity class
Show
Sam Hemelryk added a comment - Complete. The following are the only remaining uses of update_module_button in core:
  • mod/wiki module - It's getting a refactor
  • mod/resource module - Legacy
  • lib/pagelib - The page_generic_activity class
Hide
Permalink
David Mudrak added a comment -

Done in workshop, too. I just used settings_navigation::TYPE_SETTING as the node type instead of default TYPE_CUSTOM. I am not sure how these constant influence the behaviour, though.

Show
David Mudrak added a comment - Done in workshop, too. I just used settings_navigation::TYPE_SETTING as the node type instead of default TYPE_CUSTOM. I am not sure how these constant influence the behaviour, though.
Hide
Permalink
Sam Hemelryk added a comment -

Awesome thanks for doing it in workshop David. The type is used to optimize finding a node within code and also affects the css classes that get applied to a node structure. It's not of vital importance by any means so either is fine

Show
Sam Hemelryk added a comment - Awesome thanks for doing it in workshop David. The type is used to optimize finding a node within code and also affects the css classes that get applied to a node structure. It's not of vital importance by any means so either is fine

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.