Moodle

formslib: modgrade element uses deprecated link_to_popup_window as a callback for help icon

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Forms Library
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

modgrade's setHelpButton() still uses deprecated link_to_popup_window() to display a popup window with the list of scales available in the course. Because 'link_to_popup_window' is used here as a callback, it can't be simply transformed into $OUTPUT method. I am going to write new function in weblib to handle this in a similar way as htmleditor or smileys do.

Issue Links

This issue has a clone:
MDL-20920 $mform->addElement('modgrade'... Using deprecated link_to_popup_window Minor Closed
This issue will help resolve:
MDL-19318 workshop 2.0: accumulative grading strategy Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

Fixed in HEAD. setHelpButton() uses new callback function modgradehelpbutton() defined in lib/weblib.php

Show
David Mudrak added a comment - Fixed in HEAD. setHelpButton() uses new callback function modgradehelpbutton() defined in lib/weblib.php
Hide
Permalink
David Mudrak added a comment -

this bug was causing problems in many modules, including new workshop

Show
David Mudrak added a comment - this bug was causing problems in many modules, including new workshop

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.