Moodle

Regression in gradebook dependency calculation when aggregatesubcats is on

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

While working on another issue, I spotted a problem in an SQL in grade_item::depends_on(). This was introduced during new DB API syntax rewrite. Patch follows.

Issue Links

Activity

Hide
David Mudrak added a comment -

Please see the patch. I am going to commit. This is how it looks in MOODLE_19_STABLE:

WHERE gc.path LIKE '%/{$grade_category->id}/%')";
Show
David Mudrak added a comment - Please see the patch. I am going to commit. This is how it looks in MOODLE_19_STABLE:
WHERE gc.path LIKE '%/{$grade_category->id}/%')";
Hide
David Mudrak added a comment -

Committed into HEAD

Show
David Mudrak added a comment - Committed into HEAD
Hide
David Mudrak added a comment -

Sorry for the last commit. This should be the proper way. The problem was with the question mark within quotes - it was not considered as a placeholder and therefore the number of expected values and provided was different.

Show
David Mudrak added a comment - Sorry for the last commit. This should be the proper way. The problem was with the question mark within quotes - it was not considered as a placeholder and therefore the number of expected values and provided was different.
Hide
David Mudrak added a comment -

The second commit fixed this issue for me. Please review.

Show
David Mudrak added a comment - The second commit fixed this issue for me. Please review.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: