Moodle

Regression in gradebook dependency calculation when aggregatesubcats is off

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

While working on another issue, I spotted a problem in an SQL in grade_item::depends_on(). This was introduced during new DB API syntax rewrite. Patch follows.

Issue Links

Activity

Hide
David Mudrak added a comment -

See the attached patch for a proposal of fix. This actually did not cause any problem as $params just contains one more item. But as far as it was the last one, none error emerged so far. But generally, $sql and $params should be paired correctly... Still, plase give me +1 to commit

Show
David Mudrak added a comment - See the attached patch for a proposal of fix. This actually did not cause any problem as $params just contains one more item. But as far as it was the last one, none error emerged so far. But generally, $sql and $params should be paired correctly... Still, plase give me +1 to commit
Hide
David Mudrak added a comment -

Fixed in HEAD. Please review.

Show
David Mudrak added a comment - Fixed in HEAD. Please review.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: