Moodle

mnet shouldn't call mnet->init in global scope

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 1.9.8
  • Component/s: MNet
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

taken from MDL-16565

Issue Links

This issue duplicates:
MDL-16565 Upgrading 2.0 to 2008091611 get mnet related error Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Penny Leach added a comment -

partial dup of mdl-16565 but i want to close that one

Show
Penny Leach added a comment - partial dup of mdl-16565 but i want to close that one
Hide
Permalink
Penny Leach added a comment -

This is going to be a big thing to fix, I think.

The best thing I guess is for me to just bite the bullet and do it and then run with mnet partially broken, fixing all places in code that rely on $MNET being initialised , as I find them.

Show
Penny Leach added a comment - This is going to be a big thing to fix, I think. The best thing I guess is for me to just bite the bullet and do it and then run with mnet partially broken, fixing all places in code that rely on $MNET being initialised , as I find them.
Hide
Permalink
Penny Leach added a comment -

I just committed a huge patch to head to address this. I need some help with testing. Adding Jerome as watcher to help with the repository stuff.

Show
Penny Leach added a comment - I just committed a huge patch to head to address this. I need some help with testing. Adding Jerome as watcher to help with the repository stuff.
Hide
Permalink
Penny Leach added a comment -

jerome can you please qa and close?

Show
Penny Leach added a comment - jerome can you please qa and close?
Hide
Permalink
Jerome Mouneyrac added a comment -

that seems clean to me. I did some grep I didn't find anything weird ($MNET and mnet->init)
I'm about to test the rep remote plugin... closing this issue.

Show
Jerome Mouneyrac added a comment - that seems clean to me. I did some grep I didn't find anything weird ($MNET and mnet->init) I'm about to test the rep remote plugin... closing this issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.