Details
Bug
Closed
Critical
Description
It seems the Moodle code being not able to find the item to be launched, since everything is working fine when the check box for the new attempt is checked.
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hi Dan,
FYI, the proposal avoided the usage of empty() just to underline to the dev team the different values we discovered during our debugging 
: 0 comes out from the missing (under the conditions in the summary) HTTP GET parameter, scoid from loadSCO.php, retrieved by required_param().
BTW, using:
@@ -344,6 +344,9 @@
$usertracks = array();
foreach ($scoes as $sco) {
if (!empty($sco->launch)) {
+ if (empty($scoid)) {
+ $scoid = $sco->id;
+ }
if ($usertrack = scorm_get_tracks($sco->id,$user->id,$attempt)) {
if ($usertrack->status == '') {
$usertrack->status = 'notattempted';
on 1.9, the issue is fixed as expected.
FYI, find below the error returned back on the log w/o the fix:
[Thu Jan 14 09:29:24 2010] [error] [client 12.34.56.78] PHP Notice: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND attempt=2 ORDER BY element ASC' at line 1<br /><br /> SELECT * FROM mdl_scorm_scoes_track WHERE userid=334945 AND scoid= AND attempt=2 ORDER BY element ASC <ul style="text-align: left"> <li>line 687 of lib/dmllib.php: call to debugging()</li><li>line 609 of lib/dmllib.php: call to get_recordset_sql()</li> <li>line 931 of lib/dmllib.php: call to get_recordset_select()</li> <li>line 355 of mod/scorm/locallib.php: call to get_records_select()</li> <li>line 93 of mod/scorm/player.php: call to scorm_get_tracks()</li> </ul> in /path/to/moodle/lib/weblib.php on line 6962, referer: http://111.222.333.444/moodle/mod/scorm/view.php?id=2243
As you can see a SQL error is arised (AND scoid= AND) so the proposal tries to fix such a big blocking issue, upon which an error, content dependent, will be delivered to the final user.
Obviously the quality of the fix depends on the level of the comprehension we got in this short time to understand what is the real goal of the discovery of the item to be launched i.e. it could be possible that the proposal doesn't correctly address the original beahviour. This proposal stops the discovery at the first item found to be deliverable.
: 0 comes out from the missing (under the conditions in the summary) HTTP GET parameter, scoid from loadSCO.php, retrieved by required_param().
BTW, using:
@@ -344,6 +344,9 @@
$usertracks = array();
foreach ($scoes as $sco) {
if (!empty($sco->launch)) {
+ if (empty($scoid)) {
+ $scoid = $sco->id;
+ }
if ($usertrack = scorm_get_tracks($sco->id,$user->id,$attempt)) {
if ($usertrack->status == '') {
$usertrack->status = 'notattempted';
[Thu Jan 14 09:29:24 2010] [error] [client 12.34.56.78] PHP Notice: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND attempt=2 ORDER BY element ASC' at line 1<br /><br /> SELECT * FROM mdl_scorm_scoes_track WHERE userid=334945 AND scoid= AND attempt=2 ORDER BY element ASC <ul style="text-align: left"> <li>line 687 of lib/dmllib.php: call to debugging()</li><li>line 609 of lib/dmllib.php: call to get_recordset_sql()</li> <li>line 931 of lib/dmllib.php: call to get_recordset_select()</li> <li>line 355 of mod/scorm/locallib.php: call to get_records_select()</li> <li>line 93 of mod/scorm/player.php: call to scorm_get_tracks()</li> </ul> in /path/to/moodle/lib/weblib.php on line 6962, referer: http://111.222.333.444/moodle/mod/scorm/view.php?id=2243
Fix proposal:
datamodels/aicclib.php
@@ -344,6 +344,9 @@ $usertracks = array(); foreach ($scoes as $sco) { if (!empty($sco->launch)) { + if (!isset($scoid) || $scoid == 0 || $scoid == '' ) { + $scoid = $sco->id; + } if ($usertrack = scorm_get_tracks($sco->id,$user->id,$attempt)) { if ($usertrack->status == '') { $usertrack->status = 'notattempted';@@ -344,6 +344,9 @@ $usertracks = array(); foreach ($scoes as $sco) { if (!empty($sco->launch)) { + if (!isset($scoid) || $scoid == 0 || $scoid == '' ) { + $scoid = $sco->id; + } if ($usertrack = scorm_get_tracks($sco->id,$user->id,$attempt)) { if ($usertrack->status == '') { $usertrack->status = 'notattempted';