Details
-
Type:
New Feature
-
Status:
Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 1.9.7
-
Fix Version/s: DEV backlog
-
Component/s: SCORM
-
Labels:
-
Environment:LAMP, PHP 5.2.12
-
Database:MySQL
-
Difficulty:Easy
-
Affected Branches:MOODLE_19_STABLE
Description
Currently there's a really nice debug log feature for API based tracked items but nothing for HACP: while something similar could not be provided since everything is server side, it would be really useful to get some debug info during an AICC HACP session.
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hi Dan,
the calls are in {{{backup,restore}lib.php}} but I didn't ask for such actions: I will try to replicate it since I've also adjust the {full,short} site name - changing from "Dev 19" to "Dev HEAD" 
- before entering in the course and than in the activity.
BTW it could be also related with the Windows environment: mkdir(""), mkdir(false), and mkdir(null) give a "file exists" error. this is also true of a directory name consisting of any string that only contains space characters. (this was on php 5.1.2 on Windows 2000).
What about a patch like the one below?
Index: moodlelib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/moodlelib.php,v
retrieving revision 1.1396
diff -u -r1.1396 moodlelib.php
--- moodlelib.php 25 Jun 2010 13:43:50 -0000 1.1396
+++ moodlelib.php 26 Jun 2010 06:56:24 -0000
@@ -9136,6 +9136,11 @@
return false;
}
+ if (is_file($dir)) {
+ debugging('Warning. Wrong call to check_dir_exists(). $dir must be an absolute path under $CFG->dataroot ("' . $dir . '" is a file)', DEBUG_DEVELOPER);
+ return false;
+ }
+
if (is_dir($dir)) {
return true;
}
- before entering in the course and than in the activity.
BTW it could be also related with the Windows environment: mkdir(""), mkdir(false), and mkdir(null) give a "file exists" error. this is also true of a directory name consisting of any string that only contains space characters. (this was on php 5.1.2 on Windows 2000).
What about a patch like the one below?
Index: moodlelib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/moodlelib.php,v
retrieving revision 1.1396
diff -u -r1.1396 moodlelib.php
--- moodlelib.php 25 Jun 2010 13:43:50 -0000 1.1396
+++ moodlelib.php 26 Jun 2010 06:56:24 -0000
@@ -9136,6 +9136,11 @@
return false;
}
+ if (is_file($dir)) {
+ debugging('Warning. Wrong call to check_dir_exists(). $dir must be an absolute path under $CFG->dataroot ("' . $dir . '" is a file)', DEBUG_DEVELOPER);
+ return false;
+ }
+
if (is_dir($dir)) {
return true;
}
Hi Dan,
it makes sense since "Sat Jun 26 08:48:35 2010 WST" (time in Perth?) is equal to "Sat Jun 26 02:48:35 2010 CEST", according with:
- CEST, Central Europe Summer Time => UT+2:00
- WST, Western Standard Time (Australia) => UT+8:00
i.e. the fix came out after my CVS export .
BTW, the next week I'll definitely try your good review (e.g. I've missed to catch the mkdir failure and being somewhat general) and try to add an AJAX AICC log viewer using something like AJAX Logfile Tailer & Viewer, without the need for *nix tail.
Ciao,
Matteo
- CEST, Central Europe Summer Time => UT+2:00
- WST, Western Standard Time (Australia) => UT+8:00
.
BTW, the next week I'll definitely try your good review (e.g. I've missed to catch the mkdir failure and being somewhat general) and try to add an AJAX AICC log viewer using something like AJAX Logfile Tailer & Viewer, without the need for *nix tail.
Ciao,
Matteo Hi Dan,
back again w/ a new patch ({{MDL-21354_scorm_aicc_debug_v02.patch}}) starting from your review: added a web view for the debug log (> mod/scorm/datamodels/aicc_debug.php).
The new view works as per my needs 
and it should be nice that:
- [High] it could be backported into 1.9 branch too;
- [Low] it could be automatically opened launching an AICC HACP unit under DEVELOPER debug level.
Feel free of reviewing anything of this patch!
Ciao,
Matteo
and it should be nice that:
- [High] it could be backported into 1.9 branch too;
- [Low] it could be automatically opened launching an AICC HACP unit under DEVELOPER debug level.
Ciao,
Matteo hehe - no pressure on my end! - it's just unlikely I'll look at this unless an up-to-date patch is provided 
- thanks!
- thanks! 
Patch proposal:
mod/scorm/aicc.php
@@ -14,6 +14,24 @@ $_POST[$tempkey] = $value; } + function addAICCDebugLogData($text) + { + global $CFG, $USER, $scoid; + + $debugenablelog = debugging('', DEBUG_DEVELOPER); + if (!$debugenablelog || empty($text)) { + return ; + } + + $logpath = $CFG->dataroot.'/_aiccdebug_'; + if (!file_exists($logpath)) { + @mkdir($logpath); + } + + $logfile = $logpath.'/aiccdebug_'.$USER->id.'_'.$scoid.'.log'; + @file_put_contents($logfile, date('Y/m/d H:i:s O')." DEBUG $text\r\n", FILE_APPEND); + } + $command = required_param('command', PARAM_ALPHA); $sessionid = required_param('session_id', PARAM_ALPHANUM); $aiccdata = optional_param('aicc_data', '', PARAM_RAW); @@ -50,6 +68,15 @@ error('Invalid script call'); } + addAICCDebugLogData("scoid: $scoid"); + addAICCDebugLogData("mode: $mode"); + addAICCDebugLogData("status: $status"); + addAICCDebugLogData("attempt: $attempt"); + addAICCDebugLogData("command: $command"); + addAICCDebugLogData("sessionid: $sessionid"); + addAICCDebugLogData("aiccdata:\r\n$aiccdata"); + ob_start(); + if ($scorm = get_record('scorm','id',$sco->scorm)) { switch ($command) { case 'getparam': @@ -372,4 +399,8 @@ echo "error=3\r\nerror_text=Invalid Session ID\r\n"; } } + + $aiccresponse = ob_get_contents(); + addAICCDebugLogData("response:\r\n$aiccresponse"); + ob_end_flush(); ?>@@ -14,6 +14,24 @@ $_POST[$tempkey] = $value; } + function addAICCDebugLogData($text) + { + global $CFG, $USER, $scoid; + + $debugenablelog = debugging('', DEBUG_DEVELOPER); + if (!$debugenablelog || empty($text)) { + return ; + } + + $logpath = $CFG->dataroot.'/_aiccdebug_'; + if (!file_exists($logpath)) { + @mkdir($logpath); + } + + $logfile = $logpath.'/aiccdebug_'.$USER->id.'_'.$scoid.'.log'; + @file_put_contents($logfile, date('Y/m/d H:i:s O')." DEBUG $text\r\n", FILE_APPEND); + } + $command = required_param('command', PARAM_ALPHA); $sessionid = required_param('session_id', PARAM_ALPHANUM); $aiccdata = optional_param('aicc_data', '', PARAM_RAW); @@ -50,6 +68,15 @@ error('Invalid script call'); } + addAICCDebugLogData("scoid: $scoid"); + addAICCDebugLogData("mode: $mode"); + addAICCDebugLogData("status: $status"); + addAICCDebugLogData("attempt: $attempt"); + addAICCDebugLogData("command: $command"); + addAICCDebugLogData("sessionid: $sessionid"); + addAICCDebugLogData("aiccdata:\r\n$aiccdata"); + ob_start(); + if ($scorm = get_record('scorm','id',$sco->scorm)) { switch ($command) { case 'getparam': @@ -372,4 +399,8 @@ echo "error=3\r\nerror_text=Invalid Session ID\r\n"; } } + + $aiccresponse = ob_get_contents(); + addAICCDebugLogData("response:\r\n$aiccresponse"); + ob_end_flush(); ?>