Moodle

RSS feed author tag - behaviour is questionable, different in standard Moodle vs moodle.org

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.7
  • Fix Version/s: None
  • Component/s: RSS
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Moodle 1.9.7 standard RSS feeds do not contain <author> tags, which causes a problem for some readers. This behaviour is not consistent with moodle.org feeds.

Code is here:

http://cvs.moodle.org/moodle/lib/rsslib.php?revision=1.52.2.7&view=markup

There is a comment (annotate identifies it as from moodler, May 2005):

//$result .= rss_full_tag('author',3,false,$item->author);
//We put it in the description instead because it's more important 
//for moodle than most other feeds, and most rss software seems to ignore
//the author field ..
$item->description = get_string('byname','',$item->author).'. &nbsp;<p>'.$item->description.'</p>';

However, on moodle.org behaviour is different - the commented-out line at the top is no longer commented out, so you get the <author> tag in addition to the description.

If using Google Reader, this means when using moodle.org forum RSS feeds, the author name appears twice: in the right place where author name is supposed to go, then at the start of the message. It looks like this:

Re: b2e.exe file stopped working
from Installation problems by Maria Marin Padilla
by Maria Marin Padilla.

However, some other readers have a view that doesn't show content (title & author only), which means that the non-moodle.org RSS feeds do not show the author name at all because there is no author tag. Moodle.org feeds would be OK in this case.

Our users complained about the author tag being missing - presumably somebody using moodle.org did too which is why that was hacked in there...

Question: Is it really still the case that many popular RSS readers ignore the author field?

If this is not the case then we should remove the hack that adds it to the description field and add back in the author tag.

If this is still the case then we should consider whether the version currently on moodle.org (that may display the name twice) is preferable even though it duplicates the information, and should therefore go into standard code.

I'm happy to make a code change if somebody agrees what it should be I think I need to change this locally anyway.

Activity

Hide
Dan Poltawski added a comment -

Anyone have any stats on popular rss readers?

Show
Dan Poltawski added a comment - Anyone have any stats on popular rss readers?
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: