Moodle

convert/review and test all JS in gradebook

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: STABLE backlog
  • Component/s: Gradebook
  • Labels:
  • Affected Branches:
    MOODLE_20_STABLE

Issue Links

This issue will help resolve:
MDL-20935 Title attribute missing from cells on grader report Minor Reopened

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Hi Petr,
Have just attached a patch for the gradebook JS, the following changes have been made:

  • Refactored all of the JavaScript inline with our new coding style.
  • Uses YUI3 rather than YUI2 now.
  • Optimisation of the information being sent to the gradebook, removing duplicate information.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Petr, Have just attached a patch for the gradebook JS, the following changes have been made:
  • Refactored all of the JavaScript inline with our new coding style.
  • Uses YUI3 rather than YUI2 now.
  • Optimisation of the information being sent to the gradebook, removing duplicate information.
Cheers Sam
Hide
Permalink
Petr Škoda (skodak) added a comment -

hmm, found problem with undefined if(!M.util.in_array(key, this.messages)){ in ajax chat and also the yui module coding style seems problematic, working on a patch

Show
Petr Škoda (skodak) added a comment - hmm, found problem with undefined if(!M.util.in_array(key, this.messages)){ in ajax chat and also the yui module coding style seems problematic, working on a patch
Hide
Permalink
Petr Škoda (skodak) added a comment -

found the missing function in patch - committed, I have also discovered some other JS errors when hovering on the text messages, diagnosing

Show
Petr Škoda (skodak) added a comment - found the missing function in patch - committed, I have also discovered some other JS errors when hovering on the text messages, diagnosing
Hide
Permalink
Petr Škoda (skodak) added a comment -

grrrr grrrr grrrr, I wanted to post this in the chat bug, sorryyyy

Show
Petr Škoda (skodak) added a comment - grrrr grrrr grrrr, I wanted to post this in the chat bug, sorryyyy
Hide
Permalink
Sam Hemelryk added a comment -

Hi Petr,
Have attached a new patch, that does away with the YUI.add call and restructures the code accordingly.
Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Petr, Have attached a new patch, that does away with the YUI.add call and restructures the code accordingly. Cheers Sam
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.

Show
Eloy Lafuente (stronk7) added a comment - NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.