Moodle

The icon in the breadcrumb seems to be broken

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Navigation
  • Labels:
    None
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The breadcrumb (navigation bar) on each page, uses to show one icon in the last (rightest) element. It seems to be broken everywhere.

Apparently the cause is we are passing the whole URL of the image there instead of the (relative) path to it, or perhaps we are passing the URL twice..., in any case I'm ending with urls like:

http://127.0.0.1/~stronk7/git/theme/image.php?theme=standardold&image=http%3A%2F%2F127.0.0.1%2F%7Estronk7%2Fgit%2Ftheme%2Fimage.php%3Ftheme%3Dstandardold%26amp%3Bimage%3Di%252Fsettings%26amp%3Brev%3D152&rev=152

That cause error:

Warning: fopen(/Users/stronk7/Sites/moodle_data_git_head/cache/theme/standardold/pix/moodle/http/127.0.0.1/stronk7/git/theme/image.phpthemestandardoldampimagei2Fsettingsamprev152.error) [function.fopen]: failed to open stream: No such file or directory in /Users/stronk7/git_moodle/moodle/theme/image.php on line 97

Not sure if it's a navigation-bar problem (Sam) or an image.php/themes one (Petr). So I've added both here.

Ciao

Activity

Hide
Petr Škoda (skodak) added a comment -

my fault again

Show
Petr Škoda (skodak) added a comment - my fault again
Hide
Petr Škoda (skodak) added a comment -

half of the patch is in cvs, working on more icon related changes in resource like activities

Show
Petr Škoda (skodak) added a comment - half of the patch is in cvs, working on more icon related changes in resource like activities
Hide
Petr Škoda (skodak) added a comment -

should be fixed now, thanks

Show
Petr Škoda (skodak) added a comment - should be fixed now, thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: