Moodle

A patch to backup/restore description of roles in the course backup/restore process.

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.9.7
  • Fix Version/s: None
  • Component/s: Backup, Roles / Access
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The processes of backup and restore of roles in courses does not consider the role description, backuping and restoring only shortname and fullname.

Attachments

  1. File
    MDL-21708.diff
    24/Feb/10 2:43 AM
    1 kB
    Daniel Neis
  2. File
    mdl21708-2.0.diff
    09/Aug/10 10:33 PM
    1 kB
    Daniel Neis

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Neis added a comment -

The attached patch (MDL-21708.diff) add the description of the roles to backup/restore process.

Show
Daniel Neis added a comment - The attached patch (MDL-21708.diff) add the description of the roles to backup/restore process.
Hide
Permalink
Anthony Borrow added a comment -

Daniel - The patch is straightforward and looks good to me. Currently Eloy's efforts are focused on working on revising the 2.0 backup and restore. I imagine since 2.0 is a complete refactoring that it may be confusing for him to bounce between the two. It would certainly make me dizzy. For those that need the functionality then this patch will be quite helpful to them. My +1 for it to be applied. Peace - Anthony

Show
Anthony Borrow added a comment - Daniel - The patch is straightforward and looks good to me. Currently Eloy's efforts are focused on working on revising the 2.0 backup and restore. I imagine since 2.0 is a complete refactoring that it may be confusing for him to bounce between the two. It would certainly make me dizzy. For those that need the functionality then this patch will be quite helpful to them. My +1 for it to be applied. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment - - edited

I'm raising the priority to critical only because there could be a potential loss of data. The data loss is not overly critical to functionality and the patch can certainly wait until after 2.0 is released but until it is applied, the backups will not contain a role's description. Peace - Anthony

Show
Anthony Borrow added a comment - - edited I'm raising the priority to critical only because there could be a potential loss of data. The data loss is not overly critical to functionality and the patch can certainly wait until after 2.0 is released but until it is applied, the backups will not contain a role's description. Peace - Anthony
Hide
Permalink
Jonathan Champ added a comment -

This change was a vital part of the role export/import functionality that we will be using to modify roles on a test installation before pushing the changes to the production systems.

It was rather confusing to call the restore_read_xml parsing function and only get back certain parts of the data.

Thank you Daniel for creating an issue and patch for this.

Show
Jonathan Champ added a comment - This change was a vital part of the role export/import functionality that we will be using to modify roles on a test installation before pushing the changes to the production systems. It was rather confusing to call the restore_read_xml parsing function and only get back certain parts of the data. Thank you Daniel for creating an issue and patch for this.
Hide
Permalink
Daniel Neis added a comment -

Hello, Jonathan

i am happy to help with this patch.
If you are interested in import/export of roles, please take a look at MDL-17081

Regards,
Daniel

Show
Daniel Neis added a comment - Hello, Jonathan i am happy to help with this patch. If you are interested in import/export of roles, please take a look at MDL-17081 Regards, Daniel
Hide
Permalink
Daniel Neis added a comment -

Hello,

this is also true for 2.0 preview 4+, build 20100809.

I am attaching a patch to correct it in 2.0 (mdl21708-2.0.diff)

Show
Daniel Neis added a comment - Hello, this is also true for 2.0 preview 4+, build 20100809. I am attaching a patch to correct it in 2.0 (mdl21708-2.0.diff)
Hide
Permalink
Daniel Neis added a comment -

this was corrected on 2.0

Show
Daniel Neis added a comment - this was corrected on 2.0

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.