Moodle

Lesson module does not respect nolink tags

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9.7
  • Fix Version/s: None
  • Component/s: Lesson
  • Labels:
    None
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE

Description

We have experienced problems when using nolink tags in the lesson module. There is a filter that replaces links (http://...) into "a" tags (<a href="http://...">http://...</a>) ignoring the nolink tags.

We have seen that the lesson module uses format_text function with FORMAT_MOODLE as argument, and format_text uses the filter that ignores nolink tags.

format_text with FORMAT_MOODLE as argument uses text_to_html function as filter. And this function parses the text with convert_urls_into_links.

We think that the problem is on convert_urls_into_links function, because this function does not respect the nolink specification that you can find here: http://docs.moodle.org/en/Nolink_tags

For this reason, we can say that lesson module does not respect the nolink specification.

Activity

Hide
Ramon Eixarch added a comment -

Patch for 1.9 and 2.0.

Show
Ramon Eixarch added a comment - Patch for 1.9 and 2.0.
Hide
Dan Marsden added a comment -

fixing component

Show
Dan Marsden added a comment - fixing component
Hide
Martin Dougiamas added a comment -

Reassigning this to moodle.com for the time being, since Mark Nielsen is not maintaining Lesson any more. Please comment/vote/patch any crucial bugs that affect you for 2.0 to help us prioritise fixes for the upcoming release.

Show
Martin Dougiamas added a comment - Reassigning this to moodle.com for the time being, since Mark Nielsen is not maintaining Lesson any more. Please comment/vote/patch any crucial bugs that affect you for 2.0 to help us prioritise fixes for the upcoming release.
Hide
David Mudrak added a comment -

Assigning to myself as it is closely related with the filtering stuff I'm working on.

Show
David Mudrak added a comment - Assigning to myself as it is closely related with the filtering stuff I'm working on.

People

Vote (3)
Watch (2)

Dates

  • Created:
    Updated: