Moodle

pre: Some fixes to DB generators and temp tables support

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Backup, Database SQL/XMLDB
  • Labels:
    None
  • Difficulty:
    Difficult
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

While using temp tables in backup stuff, I've found some annoyances:

  • concurrent (different connection) temp tables is not working ok in PostgreSQL, MSSQL and Oracle.
  • sql generators have one PHP static cache that make things behave strange if 2 connections are used in the same request.

TODO:

  • Add ddl tests about concurrent temp tables behavior.
  • Fix concurrent temp tables behavior in PG, MSSQL and Oracle.
  • Kill the static cache in generators. It really doesn't save too much (was useful before 1.9, when we were using it to guess object names, but now we are going against he dictionary).

Ciao

Activity

Hide
Eloy Lafuente (stronk7) added a comment -
  • new tests covering temp tables concurrency added.
  • fixed postgresql (easy) and mssql (nasty)
  • static names cache erased. now always looking to dictionary tables.

TODO:

  • fix oracle temp tables concurrency.

Ciao

Show
Eloy Lafuente (stronk7) added a comment -
  • new tests covering temp tables concurrency added.
  • fixed postgresql (easy) and mssql (nasty)
  • static names cache erased. now always looking to dictionary tables.
TODO:
  • fix oracle temp tables concurrency.
Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

Oracle passes the temp tests perfectly. Closing as fixed.

Show
Eloy Lafuente (stronk7) added a comment - Oracle passes the temp tests perfectly. Closing as fixed.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: