Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.8
• Fix Version/s: 1.9.9
• Component/s: General, Performance
• Labels:

  None
• Environment:

  All

Flash detection is done with AJAX call to login/environment.php script. It is meant to be done only once per login session, but because of incorrect usage of HTML entity, it is done on every page load.

This can be fixed simply by replacing '&' entity with single '&' in AJAX GET URL:

 
Index: lib/weblib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/weblib.php,v
retrieving revision 1.970.2.167
diff -r1.970.2.167 weblib.php
2524c2524
<            "  YAHOO.util.Connect.asyncRequest('GET','".$CFG->httpswwwroot."/login/environment.php?sesskey=".sesskey()."&amp;flashversion='+flashversion.major+'.'+flashversion.minor+'.'+flashversion.release);\n".
---
>            "  YAHOO.util.Connect.asyncRequest('GET','".$CFG->httpswwwroot."/login/environment.php?sesskey=".sesskey()."&flashversion='+flashversion.major+'.'+flashversion.minor+'.'+flashversion.release);\n".

• Assignee:

  Petr Škoda (skodak)

  Reporter:

  Pasi Häkkinen

  Tester:

  Nobody

  Participants:

  Pasi Häkkinen, Petr Škoda (skodak)

• Created:

  21/Apr/10 7:45 PM

  Updated:

  13/Dec/10 6:39 PM

  Resolved:

  21/Apr/10 8:46 PM