Issue Details (XML | Word | Printable)

Key: MDL-2307
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Daniel Miksik
Votes: 12
Watchers: 5
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Special characters left in filenames after unzipping

Created: 23/Dec/04 01:01 AM   Updated: 11/May/09 11:48 PM
Return to search
Component/s: Administration
Affects Version/s: 1.5.3
Fix Version/s: 1.8.9, 1.9.5

File Attachments: 1. File unzip_clean_filenames.diff (0.9 kB)
2. File unzip_clean_filenames.diff (1.0 kB)

Environment: All
Issue Links:
Duplicate
 
Relates
 

Participants: Charles Fulton, Daniel Miksik, Deb Sarlin, Kenneth Newquist, Martin Dougiamas, Petr Skoda, Sara Arjona and Teresa Gibbison
Security Level: None
Resolved date: 08/May/09
Affected Branches: MOODLE_15_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
When an uploaded zip file is unzipped in the Files area, special characters are left in the unzipped files - resulting in Sorry, the requested file could not be found message when trying to access those files. Tested at my site and moodle.org today.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 06/May/09 04:48 PM
MDL-2307, MDL-18415 - improved unzipping - now properly removing forbidden chars and symlinks
MODIFY lib/moodlelib.php   Rev. 1.960.2.130    (+71 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 06/May/09 04:49 PM
MDL-2307, MDL-18415 - improved unzipping - now properly removing forbidden chars and symlinks; backported from MOODLE_19_STABLE
MODIFY lib/moodlelib.php   Rev. 1.837.2.97    (+72 -3 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 07/May/09 06:47 PM
MDL-2307 improved file name cleanup during unzip
MODIFY lib/moodlelib.php   Rev. 1.960.2.131    (+23 -28 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 07/May/09 06:48 PM
MDL-2307 improved file name cleanup during unzip; backported from MOODLE-19_STABLE
MODIFY lib/moodlelib.php   Rev. 1.837.2.98    (+16 -28 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 08/May/09 12:44 AM
MDL-2307 fixing unzip regression, sorry
MODIFY lib/moodlelib.php   Rev. 1.837.2.99    (+14 -5 lines)
MODIFY lib/moodlelib.php   Rev. 1.837.2.100    (+3 -3 lines)