Moodle

groupings and groups problems

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Groups
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Playing with groups and groupings, go these not working ok:

  • Groups interface: Editing one group (/group/group.php), add some image in the description and also add one picture. Save the group. Then edit it again. The image in description is ok but the picture isn't (although seems to be there as far as I can see the group icon in the upper left corner). I see one "no files attached" in the icon area.
  • Groupings interface: Simply broken (group/groupings.php). Error: Fatal error: Call to a member function make_active() on a non-object in /Users/stronk7/cvs_moodle/moodle_head/group/groupings.php on line 53

Ciao

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

yes, it was always like this, if you upload a new image it overrides the old one, you can not delete it, there is no file manager, just upload new image...

Show
Petr Škoda (skodak) added a comment - yes, it was always like this, if you upload a new image it overrides the old one, you can not delete it, there is no file manager, just upload new image...
Hide
Martin Dougiamas added a comment -

I'm looking at the groupings problem atm

Show
Martin Dougiamas added a comment - I'm looking at the groupings problem atm
Hide
Martin Dougiamas added a comment -

OK, just a small regression from the move of groups to under "users"

Show
Martin Dougiamas added a comment - OK, just a small regression from the move of groups to under "users"
Hide
Paul Nicholls added a comment -

Hi guys,
I see Martin's commit a few hours ago fixes the "Groupings" tab - it looks like the "users" node has now had a string key assigned, which is good as it simplifies things... but as per my ticket MDL-22903, the "Overview" tab suffers from the same issue (and there's also a bug in the find() function which could do with fixing)

-Paul

Show
Paul Nicholls added a comment - Hi guys, I see Martin's commit a few hours ago fixes the "Groupings" tab - it looks like the "users" node has now had a string key assigned, which is good as it simplifies things... but as per my ticket MDL-22903, the "Overview" tab suffers from the same issue (and there's also a bug in the find() function which could do with fixing) -Paul
Hide
Paul Nicholls added a comment -

Sorry - just to clarify, the "Overview" tab currently works, but the menu does not expand to Users -> Groups as it does on the Groups and Groupings tabs, because the offending line is commented out (with a TODO) in CVSHEAD. See MDL-22903 for further details - I'm about to post again over there.

Show
Paul Nicholls added a comment - Sorry - just to clarify, the "Overview" tab currently works, but the menu does not expand to Users -> Groups as it does on the Groups and Groupings tabs, because the offending line is commented out (with a TODO) in CVSHEAD. See MDL-22903 for further details - I'm about to post again over there.
Hide
Eloy Lafuente (stronk7) added a comment -

I'm reopening this because of related:

The edition interface seems to work ok now, great!

But the overview tab isn't able to show any images introduced in the grouping description (notices/warnings can be seen in the request of the image).

This and comments from Paul about the groupings needing to be shown in the settings menu.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - I'm reopening this because of related: The edition interface seems to work ok now, great! But the overview tab isn't able to show any images introduced in the grouping description (notices/warnings can be seen in the request of the image). This and comments from Paul about the groupings needing to be shown in the settings menu. Ciao
Hide
Martin Dougiamas added a comment -

Fixed all that now.

Show
Martin Dougiamas added a comment - Fixed all that now.

People

Dates

  • Created:
    Updated:
    Resolved: