Moodle

search over visible glossaries only

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.5
  • Fix Version/s: None
  • Component/s: Glossary
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_15_STABLE

Description

The function glossary_get_entries_search() should search over visible glossaries only unless the user is a teacher.

Activity

Hide
Martin Dougiamas added a comment -

From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 01:52 AM:

Uhm, yeah! I'll do it now!

and terms should be linked only it their glossary is visible too! Although perhaps this will break the cache implementation. I suppose that it's better to avoid auto-linking for everybody, isn't it?

From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 02:09 AM:

Uhm, yeah! I'll do it now!

and terms should be linked only it their glossary is visible too! Although perhaps this will break the cache implementation. I suppose that it's better to avoid auto-linking for everybody, isn't it?

From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 03:01 AM:

Now:

  • students only view entries from visible glossaries.
  • teachers view any entry from their course and only visible from global glossaries.
  • admins view any entry from any course and any entry from global glossaries too.

Now let's go to filter...to maintain filter cache, I'm going to forbide linking to everybody to hidden glossaries.

PS:Sorry by my previous duplicated post. Stupid fingers! :-D

From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 03:30 AM:

Done. Now the filter only links against visible glossaries. For everybody (admin, teacher, student) the same behaviour.

Updating to fixed. I'll close it in some days if there aren't problems reported.

Ciao

From Eloy Lafuente (stronk7 at moodle.org) Saturday, 12 March 2005, 03:24 AM:

closing now

Show
Martin Dougiamas added a comment - From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 01:52 AM: Uhm, yeah! I'll do it now! and terms should be linked only it their glossary is visible too! Although perhaps this will break the cache implementation. I suppose that it's better to avoid auto-linking for everybody, isn't it? From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 02:09 AM: Uhm, yeah! I'll do it now! and terms should be linked only it their glossary is visible too! Although perhaps this will break the cache implementation. I suppose that it's better to avoid auto-linking for everybody, isn't it? From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 03:01 AM: Now:
  • students only view entries from visible glossaries.
  • teachers view any entry from their course and only visible from global glossaries.
  • admins view any entry from any course and any entry from global glossaries too.
Now let's go to filter...to maintain filter cache, I'm going to forbide linking to everybody to hidden glossaries. PS:Sorry by my previous duplicated post. Stupid fingers! :-D From Eloy Lafuente (stronk7 at moodle.org) Friday, 18 February 2005, 03:30 AM: Done. Now the filter only links against visible glossaries. For everybody (admin, teacher, student) the same behaviour. Updating to fixed. I'll close it in some days if there aren't problems reported. Ciao From Eloy Lafuente (stronk7 at moodle.org) Saturday, 12 March 2005, 03:24 AM: closing now
Hide
Michael Blake added a comment -

assign to a valid user

Show
Michael Blake added a comment - assign to a valid user
Hide
Paul Fynn added a comment -

I'm currently trying to limit access to a global glossary to teachers only (Moodle 1.9.5), but whatever local permissions I set on Glossary, students still appear to be able to see the main glossary.

Is this the same issue as teh one resolved here?
Thanks
Paul

Show
Paul Fynn added a comment - I'm currently trying to limit access to a global glossary to teachers only (Moodle 1.9.5), but whatever local permissions I set on Glossary, students still appear to be able to see the main glossary. Is this the same issue as teh one resolved here? Thanks Paul

Dates

  • Created:
    Updated:
    Resolved: