Moodle

CodeSniffer doesn't recognize $OUTPUT as a valid variable name.

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0.1
  • Fix Version/s: None
  • Component/s: Other
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

In the file lib/pear/PHP/CodeSniffer/Standards/Moodle/Sniffs/NamingConventions there's a list of variables that are "ok" to not follow the standard naming practices. $OUTPUT is not on this list causing CodeSniffer to complain every time it seems the $OUTPUT variable.

I've attached a patch to resolve the problem.

Issue Links

This issue will help resolve:
MDL-19247 PHP CodeSniffer: tool for coding standard consistency Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tyler Bannister added a comment -

Oops. Fixed the missing comma.

Show
Tyler Bannister added a comment - Oops. Fixed the missing comma.
Hide
Permalink
Tyler Bannister added a comment -

$ADMIN is also missing from the list.

Show
Tyler Bannister added a comment - $ADMIN is also missing from the list.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.