Moodle

Blog visibility update error

Details

  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

As reported by Jarrod Holder in http://moodle.org/mod/forum/discuss.php?d=169588

Updated a play site from 1.9.10 to 2.0.2. Trying to run the Blog visibility update that's recommended and I get the following error:

Notice: Undefined property: stdClass::$message in /mysite/mod/forum/lib.php on line 4113

Followed by "Error writing to database"

Issue Links

Activity

Hide
Andy McCall added a comment -

I am also having the same problem, I have recently upgraded from 1.9.11+ to 2.0.

The upgrade was successful but when logging in to the admin page I had the following warning:

"Your site is using an old blog visibility setting, the blog visibility upgrade is recommended."

Running the upgrade produces the screenshot attached.

Show
Andy McCall added a comment - I am also having the same problem, I have recently upgraded from 1.9.11+ to 2.0. The upgrade was successful but when logging in to the admin page I had the following warning: "Your site is using an old blog visibility setting, the blog visibility upgrade is recommended." Running the upgrade produces the screenshot attached.
Show
Aparup Banerjee added a comment - a patch is up at https://github.com/nebgor/moodle/compare/mistress...MDL-26643
Hide
Aparup Banerjee added a comment -

thanks for review rosie, PULL-422 created

Show
Aparup Banerjee added a comment - thanks for review rosie, PULL-422 created
Hide
Jarrod Holder added a comment -

Updated bloglevelupgrade.php as listed and worked great. Thanks! One step closer to moving our site to 2.0

Show
Jarrod Holder added a comment - Updated bloglevelupgrade.php as listed and worked great. Thanks! One step closer to moving our site to 2.0
Hide
Eloy Lafuente (stronk7) added a comment -

This has been integrated for testing this week, thanks.

Note: Just saw that, immediately below the changed line, there is one:

$discussion->messageformat = $forum->introformat;

Just guessing if that is really the best format to be used in the conversion, specially because forum_get_course_forum() doesn't define it, hence = 0 (FORMAT_MOODLE).

Ciao

Show
Eloy Lafuente (stronk7) added a comment - This has been integrated for testing this week, thanks. Note: Just saw that, immediately below the changed line, there is one:
$discussion->messageformat = $forum->introformat;
Just guessing if that is really the best format to be used in the conversion, specially because forum_get_course_forum() doesn't define it, hence = 0 (FORMAT_MOODLE). Ciao
Hide
Dongsheng Cai added a comment -

Closing Thanks

Show
Dongsheng Cai added a comment - Closing Thanks
Hide
Helen Foster added a comment -

Reopening so that a 2.0.3 fix version can be set. Also, let's wait until the weekly package is available before closing. Apologies for the extra notification emails.

Show
Helen Foster added a comment - Reopening so that a 2.0.3 fix version can be set. Also, let's wait until the weekly package is available before closing. Apologies for the extra notification emails.
Hide
Helen Foster added a comment -

Aparup, thanks for fixing.

Show
Helen Foster added a comment - Aparup, thanks for fixing.
Hide
Petr Škoda (skodak) added a comment -

the discussion format is not correct, I am going to file new pull in MDL-26876

Show
Petr Škoda (skodak) added a comment - the discussion format is not correct, I am going to file new pull in MDL-26876

Dates

  • Created:
    Updated:
    Resolved: