Issue Details (XML | Word | Printable)

Key: MDL-2674
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Helen Foster
Reporter: Penny Leach
Votes: 7
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13847

backup always backsup/restores groups regardless of user settings

Created: 04/Mar/05 09:23 AM   Updated: 03/Oct/09 02:16 AM
Return to search
Component/s: Backup, Groups
Affects Version/s: 1.5.2, 1.9
Fix Version/s: 1.9.1

File Attachments: 1. File patch-Bug-3132-group-backup-option-7core.diff (14 kB)
2. File patch-Bug-3132-group-backup-option-8core.diff (16 kB)

Environment: All
Issue Links:
Duplicate
 
Relates
 

Database: Any
Participants: David Mudrak, Eloy Lafuente (stronk7), Helen Foster, Martin Dougiamas, Nick Freear, Penny Leach, Petr Skoda and Timothy Takemoto
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 21/Mar/08
Affected Branches: MOODLE_15_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
It seems to me that backup and restore will always include groups and group memberships, regardless of whether user info is selected or not.

I think the correct behaviour would be to always backup/restore group names, but only backup/restore the group memberships if user info has been selected.

Thoughts?

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear committed 10 files to 'Moodle CVS' - 10/Dec/07 07:26 PM
Fixes bug MDL-2674, "backup always backsup/restores groups regardless of user settings" - restore group/grouping option.
MODIFY lang/en_utf8/moodle.php   Rev. 1.155    (+3 -2 lines)
ADD lang/en_utf8/help/grouprestore.html   Rev. 1.1    (+0 -0 lines)
MODIFY backup/restore_form.html   Rev. 1.64    (+32 -1 lines)
MODIFY mod/wiki/restorelib.php   Rev. 1.18    (+3 -2 lines)
MODIFY backup/restorelib.php   Rev. 1.295    (+60 -7 lines)
MODIFY mod/data/restorelib.php   Rev. 1.29    (+2 -2 lines)
MODIFY backup/restore_check.html   Rev. 1.49    (+4 -1 lines)
MODIFY mod/forum/restorelib.php   Rev. 1.61    (+3 -2 lines)
MODIFY mod/chat/restorelib.php   Rev. 1.23    (+3 -2 lines)
MODIFY lang/en_utf8/group.php   Rev. 1.26    (+4 -1 lines)
Mitsuhiro Yoshida committed 12 files to 'Lang CVS' - 11/Dec/07 05:09 AM
Translated new strings for group and grouping MDL-2674.
Addin a new translated help file for group restore MDL-2674.
Brushed up translated strings and help files.
MODIFY ja_utf8/help/feedback/mapcourse.html   Rev. 1.6    (+1 -1 lines)
MODIFY ja_utf8/glossary.php   Rev. 1.37    (+3 -3 lines)
MODIFY ja_utf8/help/question/permissions.html   Rev. 1.3    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.221    (+8 -8 lines)
MODIFY ja_utf8/group.php   Rev. 1.26    (+3 -1 lines)
MODIFY ja_utf8/README   Rev. 1.589    (+1 -1 lines)
MODIFY ja_utf8/resource.php   Rev. 1.27    (+3 -3 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.262    (+3 -2 lines)
MODIFY ja_utf8/help/lesson/questiontypes.html   Rev. 1.18    (+2 -3 lines)
ADD ja_utf8/help/grouprestore.html   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/auth.php   Rev. 1.57    (+2 -2 lines)
MODIFY ja_utf8/block_attendance.php   Rev. 1.9    (+2 -1 lines)
martignoni committed 2 files to 'Lang CVS' - 14/Dec/07 07:15 PM
Fixes bug MDL-2674, "backup always backsup/restores groups regardless of user settings" - restore group/grouping option.
MODIFY fr_utf8/moodle.php   Rev. 1.186    (+2 -1 lines)
MODIFY fr_utf8/group.php   Rev. 1.31    (+3 -1 lines)
Petr Skoda committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Mar/08 06:27 AM
MDL-2674 backup always backsup/restores groups regardless of user settings; backported from HEAD
MODIFY backup/restorelib.php   Rev. 1.283.2.29    (+49 -4 lines)
MODIFY lang/en_utf8/help/grouprestore.html   Rev. 1.1.2.2    (+33 -0 lines)
MODIFY backup/restore_check.html   Rev. 1.48.2.2    (+4 -1 lines)
MODIFY backup/restore_form.html   Rev. 1.60.2.5    (+33 -1 lines)
MODIFY lang/en_utf8/group.php   Rev. 1.22.2.4    (+4 -1 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 18/Mar/08 06:33 AM
MDL-2674 backup always backsup/restores groups regardless of user settings; remerged from MOODLE_19_STABLE
MODIFY backup/restorelib.php   Rev. 1.314    (+3 -1 lines)
MODIFY backup/restore_form.html   Rev. 1.66    (+4 -3 lines)
Petr Skoda committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Mar/08 06:33 AM
MDL-2674 backup always backsup/restores groups regardless of user settings; backported from HEAD
MODIFY mod/data/restorelib.php   Rev. 1.27.2.2    (+2 -2 lines)
MODIFY mod/chat/restorelib.php   Rev. 1.22.6.2    (+2 -2 lines)
MODIFY mod/wiki/restorelib.php   Rev. 1.17.6.1    (+3 -2 lines)
MODIFY mod/forum/restorelib.php   Rev. 1.60.4.4    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Mar/08 06:54 AM
MDL-2674 adding $cm->grouping reset if groupings not restored; removed info about groups included in backup - they are always included, and there will not be any global groups/groupings
MODIFY backup/restore_form.html   Rev. 1.60.2.6    (+2 -2 lines)
MODIFY backup/restorelib.php   Rev. 1.283.2.30    (+17 -14 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 18/Mar/08 06:57 AM
MDL-2674 adding $cm->grouping reset if groupings not restored; removed info about groups included in backup - they are always included, and there will not be any global groups/groupings; merged from MOODLE_19_STABLE
MODIFY backup/restore_form.html   Rev. 1.67    (+2 -2 lines)
MODIFY backup/restorelib.php   Rev. 1.315    (+17 -14 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/Mar/08 07:09 AM
MDL-2674 removed hardcoded renaming of groupings depending on changed course shortname
MODIFY backup/restorelib.php   Rev. 1.316    (+2 -9 lines)
wildgirl committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 21/Mar/08 05:48 AM
MDL-2674 PHP code removed from help file
MODIFY lang/en_utf8/help/grouprestore.html   Rev. 1.1.2.3    (+10 -29 lines)
wildgirl committed 1 file to 'Moodle CVS' - 21/Mar/08 06:07 AM
MDL-2674 PHP code removed from help file, small rewording
MODIFY lang/en_utf8/help/grouprestore.html   Rev. 1.2    (+2 -31 lines)
wildgirl committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 21/Mar/08 06:07 AM
MDL-2674 PHP code removed from help file, small rewording
MODIFY lang/en_utf8/help/grouprestore.html   Rev. 1.1.2.4    (+2 -12 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 21/Mar/08 06:16 AM
MDL-2674 minor lang improvement
MODIFY lang/en_utf8/group.php   Rev. 1.22.2.5    (+1 -0 lines)
MODIFY backup/restore_form.html   Rev. 1.60.2.8    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 21/Mar/08 06:17 AM
MDL-2674 minor lang improvement; backported from MOODLE_19_STABLE
MODIFY lang/en_utf8/group.php   Rev. 1.27    (+1 -0 lines)
MODIFY backup/restore_form.html   Rev. 1.69    (+3 -3 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 21/Mar/08 10:05 AM
Translated a new string for group.MDL-2674.
Updated a translated help file for group restore based on lang/en_utf8 change MDL-2674.
MODIFY ja_utf8/README   Rev. 1.667    (+1 -1 lines)
MODIFY ja_utf8/help/grouprestore.html   Rev. 1.2    (+2 -28 lines)
MODIFY ja_utf8/group.php   Rev. 1.29    (+33 -32 lines)
martignoni committed 1 file to 'Lang CVS' - 25/Mar/08 03:11 AM
MDL-2674: new help file added
ADD fr_utf8/help/grouprestore.html   Rev. 1.1    (+0 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 25/Mar/08 03:13 AM
MDL-2674 new string added
MODIFY fr_utf8/group.php   Rev. 1.32    (+2 -1 lines)