Moodle

META - Several repository & file picker bugs

Details

  • Affected Branches:
    MOODLE_20_STABLE

Description

  • When using the file picker and you have "View as List" activated, then paging doesn't work. It appears that the page number is not passed in the AJAX request, so the first page's content is always returned.
  • The default when viewing content in the repository file picker is the "View as Icons", but it doesn't initially render as "Selected" or "Highlighted". It's only after "View as List" has been selected and then "View as Icons" has been reselected.
  • When searching, should this dialog be modal? Currently you can mess around with the main file picker window when the search dialog is up.
  • The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name].
  • When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
  • The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog.
  • Script error displays when selecting a file while file are displayed in view as list mode in IE8. Error details: 
    Message: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.
Line: 2649
Char: 25
Code: 0
URI: http://yui.yahooapis.com/combo?2.8.2/build/treeview/treeview-debug.js
  • (Note: might be related to above issue with pushing return/enter in search dialog) Error when enter/return key is pressed in the search dialog in IE8. Error details: 
    Message: Invalid argument.
Line: 482
Char: 4
Code: 0
URI: http://yui.yahooapis.com/combo?2.8.2/build/yahoo-dom-event/yahoo-dom-event.js&2.8.2/build/connection/connection-debug.js&2.8.2/build/logger/logger-debug.js

Issue Links

This issue will help resolve:
MDL-27178 'Upload a file...' button does not bring focus to the File picker Major Open
MDL-27725 File Picker gets repositioned when error is encountered Minor Open
This issue will be resolved by:
MDL-28019 Implement file management for HTML-related file areas Blocker Open
MDL-31907 META: File Usability 2.3 Blocker Open
MDL-26388 Handle duplicate files uploaded through filepicker Blocker Closed
This issue has a non-specific relationship to:
MDL-23989 The File Repository has no obvious way to delete a file. Minor Open
Progress
Resolved Sub-Tasks Unresolved Sub-Tasks

Sub-Tasks

1.
 The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name]. Sub-task Closed Closed Dongsheng Cai
 
2.
 Filepicker 'view as list' not working with paging Sub-task Closed Closed Dongsheng Cai
 
3.
 View as Icons button is not highlighted in filepicker Sub-task Closed Closed Dongsheng Cai
 
4.
 Filepicker search dialog should be modal Sub-task Closed Closed Dongsheng Cai
 
5.
 The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog. Sub-task Closed Closed Dongsheng Cai
 
6. Filepicker error when running under ie8 Sub-task Open Open Dongsheng Cai
 
7. Uninformative error when user session has timed out Sub-task Open Open Dongsheng Cai
 
8. Search modal appears behind the File Picker in Safari Sub-task Open Open Dongsheng Cai
 
9. Undefined mimetype strings Sub-task Open Open Dongsheng Cai
 
10. File picker error when selecting an alternative image Sub-task Open Open Dongsheng Cai
 
11. Results display as Icons even though List is Selected as Format Sub-task Open Open Dongsheng Cai
 
12. Double clicking the Search link creates odd behavior Sub-task Open Open Dongsheng Cai
 
13. File Picker does not work on paginated pages Sub-task Open Open Dongsheng Cai
 
14. File Picker pagination on search does not work Sub-task Open Open Dongsheng Cai
 
15. File picker paging bar does not work with JS disabled Sub-task Open Open Marina Glancy
 
16. List view in Filepicker shows only default Server files (course) Sub-task Open Open Dongsheng Cai
 
17. File picker pagination list issue Sub-task Open Open Dongsheng Cai
 
18. ERROR: Invalid JSON string on filepicker Sub-task Development in progress Development in progress Dongsheng Cai
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dongsheng Cai added a comment -

Adding this to stable backlog.

Show
Dongsheng Cai added a comment - Adding this to stable backlog.
Hide
Permalink
Michael Blake added a comment -

Raising priority on this issue: it's been reported by a MP and should greatly improve repository usability.

Show
Michael Blake added a comment - Raising priority on this issue: it's been reported by a MP and should greatly improve repository usability.
Hide
Permalink
Mark Nielsen added a comment -

Adding a few more discovered issues.

Please feel free to ask about more details on any of the issues.

Show
Mark Nielsen added a comment - Adding a few more discovered issues. Please feel free to ask about more details on any of the issues.
Hide
Permalink
Martin Dougiamas added a comment -

Dongsheng can you please make some subtasks for these and tackle the low hanging fruit

Show
Martin Dougiamas added a comment - Dongsheng can you please make some subtasks for these and tackle the low hanging fruit
Hide
Permalink
Dongsheng Cai added a comment -

issue 5 is related to MDL-23989

Show
Dongsheng Cai added a comment - issue 5 is related to MDL-23989
Hide
Permalink
Mark Nielsen added a comment -

Thanks so much on the work on this issue thus far!!!

I was wondering if this was going or has been addressed:

When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.

Show
Mark Nielsen added a comment - Thanks so much on the work on this issue thus far!!! I was wondering if this was going or has been addressed:
When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
Hide
Permalink
Dongsheng Cai added a comment -

Hi Mark

The 'file exists' issue will be fixed by MDL-26388, we already have a solution for this

Show
Dongsheng Cai added a comment - Hi Mark The 'file exists' issue will be fixed by MDL-26388, we already have a solution for this
Hide
Permalink
Michael Blake added a comment -

MP has again flagged this issue as causing problems for their client. Please give it priority.

Show
Michael Blake added a comment - MP has again flagged this issue as causing problems for their client. Please give it priority.
Hide
Permalink
Dongsheng Cai added a comment -

I will focus on those issues for next sprint.

Show
Dongsheng Cai added a comment - I will focus on those issues for next sprint.
Hide
Permalink
Silverio Armani added a comment -

Hi Dongsheng,

Please, could you add MDL-27025 as a sub-task?

Show
Silverio Armani added a comment - Hi Dongsheng, Please, could you add MDL-27025 as a sub-task?
Hide
Permalink
Dongsheng Cai added a comment -

A lot of issues here should be fixed by MDL-31907

Show
Dongsheng Cai added a comment - A lot of issues here should be fixed by MDL-31907

People

Vote (1)
Watch (7)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.