Moodle

Problems with Safari and the new "overwrite files" dialog

Details

Description

This is one followup of MDL-26388.

In the testing phase it has been detected that the new "overwrite files" dialog, allowing to replace/rename/cancel is shown under any other dialog (file picker, add image...) when using the Safari browser (see attached image).

It would be great to have this fixed ASAP for quick integration. Ciao

Issue Links

This issue has a non-specific relationship to:
MDL-28019 Implement file management for HTML-related file areas Blocker Open
MDL-26388 Handle duplicate files uploaded through filepicker Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Triaging and assigning straight to Dongsheng.

Show
Eloy Lafuente (stronk7) added a comment - Triaging and assigning straight to Dongsheng.
Hide
Permalink
Sam Hemelryk added a comment -

Hi DS,

This looks like its going to be as simple as setting a higher z-index on the overlay.
If it is that simple could you please get a patch up and I'll integrate it today in time for the 2.0.3 release.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi DS, This looks like its going to be as simple as setting a higher z-index on the overlay. If it is that simple could you please get a patch up and I'll integrate it today in time for the 2.0.3 release. Cheers Sam
Hide
Permalink
Dongsheng Cai added a comment -

For undknown reason, safari completely ignore zindex property, I set zindex to 99999992, in safari, it uses zindex:11 no matter what I put in js

Show
Dongsheng Cai added a comment - For undknown reason, safari completely ignore zindex property, I set zindex to 99999992, in safari, it uses zindex:11 no matter what I put in js
Hide
Permalink
Dongsheng Cai added a comment -

Found the solution, seems YUI failed to make modal dialog really 'modal', I removed modal option, use zIndex property solve the problem

Show
Dongsheng Cai added a comment - Found the solution, seems YUI failed to make modal dialog really 'modal', I removed modal option, use zIndex property solve the problem
Hide
Permalink
Sam Hemelryk added a comment -

Thanks DS this has been integrated now.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks DS this has been integrated now. Cheers Sam
Hide
Permalink
Aparup Banerjee added a comment -

tested on safari for windows.
the dialog appears fine for me in the proper Z order.

(note: the file choosing dialog needed one more click as if focus was still elsewhere, but that may have been effects of my terminal client connecting to windows.)

Show
Aparup Banerjee added a comment - tested on safari for windows. the dialog appears fine for me in the proper Z order. (note: the file choosing dialog needed one more click as if focus was still elsewhere, but that may have been effects of my terminal client connecting to windows.)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yay, as a Safari-er, many thanks. Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Yay, as a Safari-er, many thanks. Closing, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Integration date:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.