Moodle

Hi Dan,t
A client of mine, who is experiencing a lot of problems with SCORM mainly with the height of the frame, is asking what the timeline for coming up with a patch is likly to be? Any likelyhood of this being incorporated into Moodle 2.1.1 Dan? Or are we looking at a long wait?

Cheers
Mary

Hi Mary,

I'm about to take some leave over the next few weeks but I'll try to take a look sometime this week - if I don't manage to take a look this week then it won't be until at least mid August before i get a chance to look at it again.

of course - if your client was willing to fund the time to look at the issue it might happen faster.

btw - there are probably at least 2 other issues I'll be looking at before this one - see this list for the issues on the stable backlog:
http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MDL+AND+component+%3D+SCORM+AND+resolution+%3D+Unresolved+AND+fixVersion+%3D+%22STABLE+backlog%22+ORDER+BY+priority+DESC

also - if you're wanting to do this at a site wide level in the interim you could change this var in scorm/module.js:
minHeight: 600,

to something like:
minHeight: 1200,

Thanks for this Dan...this might just be the fix I'm looking for.

I've just been looking at MDL-26482 and I wonder if the TOC is disabled we should strip the player out and just embed the SCORM in a standard object without the fancy player?

What you are suggesting sounds like a better idea. However, the fix you gave earlier is working great...the player displays to its full hight as required. The problem now is the Moodle custom-menu with its drop-down menu items, where each level of the drop-down menu has its own z-index value. But no matter what value you give it, even a billion will not get above the player.

I have read it's the way it's embedded in the page. Is this correct, and if so is there a way to allow the custom menu to drop-down over the SCORM player?

A fix for this has been suggested on this web page http://slightlymore.co.uk/flash-and-the-z-index-problem-solved/ which suggests that by adding an extra parameter in the code one uses to embed a file...<param name="wmode" value="opaque" /> it changes the way the flash object is embedded.

It's all way above me all this sort of talk...so any advice...help...would be great.

Cheers
Mary

unfortuantely you'll need to add that to the code inside your SCORM package - The SCORM player doesn't any flash but a lot of the packages do... Let me know if you find another method that involves changing the code in the player and I'd be happy to include it.

thanks,

Dan

Thanks to Piers who took a look at this and put together this patch!!!!

Hi guys,
Thanks for the great work on this so far. I'm sending this back around so that the height guessing code there can be improved.
I see that the JS script already has access to the YUI2 libraries so certainly using something like the following would be a win for cross browser compatibility.

YAHOO.util.Dom.getViewportWidth();
YAHOO.util.Dom.getViewportHeight();

Cheers
Sam

hmmm - do you have time to test a new patch Sam? - I've already spent too much time on this and it's all non-chargeable work at this stage... Holding this patch back also means the more critical issue MDL-28295 can't go in.

I've asked Piers if he has time to take another look.... but I'd really like to get this and MDL-28295 in this week.

Piers had some time!
https://github.com/piersharding/moodle/commit/00c53985a82c238f7e8d436b8cdb2268bb4de138

I'll fix the branches above and resubmit now.

updated code from Piers - thanks Piers!

Thanks guys for getting that tidied up, its now been integrated. Cheers Sam

thank Sam!

Tested on Gentoo FF 5.0 and Chromium 12.0. Works well - the player adjusts the height as the window resizes. I just had to force reload to clear old JS from the local browser cache. Which is a bit weird as I expected the javascript revision is increased and the file reloaded automatically. Maybe it is because the version of mod_scorm was not increased?

I still have the issue that my scorm content only is displayed within a 400px height div.

Jens - please ask for help in the community forums - height can be controlled by a number of different things - the SCORM player in latest 2.xstable branches is designed to use the max space available by the browser and Moodle Theme.

If you aren't using the latest stable 2.x release, please upgrade before you ask for help.
If you are using a custom theme - please try using a standard one to see if it makes any difference.
Check your SCORM package itself to make sure it isn't limiting the height by itself.
Read this FAQ before asking for help in the forums:
http://docs.moodle.org/20/en/SCORM_FAQ#Asking_for_Help_in_the_SCORM_Forum