Moodle

In bulk user upload, city is required but not marked as required

Details

Description

In uploaduser_form.php the city field is required but not marked as such in the form. It's possible, though unlikely, to run across a use case where there isn't a default value that gets filled in for city, and in any case marking it as required is just best practice.

Fix for 2.1: https://github.com/mackensen/moodle/commit/116fc1a0f2ba9326500ad8ad42d8548e72f80079

Issue Links

This issue has a non-specific relationship to:
MDL-28211 Upload bulk user: add validation to required field to upload file Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this.

I've put it on our backlog and we'll try to get to it as soon as we can.

Show
Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
Hide
Permalink
Rossiani Wijaya added a comment -

Thanks Charles for providing the patch.

In addition to Charles' patch, I add invalid city field notice to the preview table (right after the upload page).

Diff url is available above.

Thanks

Show
Rossiani Wijaya added a comment - Thanks Charles for providing the patch. In addition to Charles' patch, I add invalid city field notice to the preview table (right after the upload page). Diff url is available above. Thanks
Hide
Permalink
Aparup Banerjee added a comment -

Hi Rossi,
This seems to work fine for me. when city isn't filled in it shows error about the field being required.
code seems to be inline with rest of code. i haven't looked deeper into it.
cheers,
Aparup

Show
Aparup Banerjee added a comment - Hi Rossi, This seems to work fine for me. when city isn't filled in it shows error about the field being required. code seems to be inline with rest of code. i haven't looked deeper into it. cheers, Aparup
Hide
Permalink
Rossiani Wijaya added a comment -

Thanks Apu for testing.

submitting for integration.

Show
Rossiani Wijaya added a comment - Thanks Apu for testing. submitting for integration.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

This has been integrated, thanks! (master, 20 and 21).

Show
Eloy Lafuente (stronk7) added a comment - This has been integrated, thanks! (master, 20 and 21).
Hide
Permalink
Sam Hemelryk added a comment -

Congratulations - this fix has just been released in the weeklies.

Show
Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

Dates

  • Created:
    Updated:
    Resolved:
    Integration date:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.