[#MDL-28283] Course Completion will not allow completion dates to be set outside of the range 2000 - 2010 - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.3, 2.1
Fix Version/s: 2.1.5, 2.2.2, STABLE Sprint 17
Component/s: Course completion
Labels:
- patch
- triaged

Testing Instructions:
1. Follow steps 1-5 as specified in the description.
2. Now you should see years in the range 1970-2020 in the drop down
Workaround:

Hide

I've created a patch to work around this issue. This patch was created against Moodle Head however the code it affects did not change between Moodle 2.0.3 and 2.1. I've only been able to perform limited testing of the patch, but for my installation (Moodle 2.0.3+, no contrib modules) it works.

Show
I've created a patch to work around this issue. This patch was created against Moodle Head however the code it affects did not change between Moodle 2.0.3 and 2.1. I've only been able to perform limited testing of the patch, but for my installation (Moodle 2.0.3+, no contrib modules) it works.
Database:

Any
Difficulty:
Easy
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull 2.1 Branch:
~~MDL-28283~~-m21
Pull 2.1 Diff URL:
https://github.com/ankitagarwal/moodle/compare/MOODLE_21_STABLE...MDL-28283-m21
Pull 2.2 Branch:
~~MDL-28283~~-m22
Pull 2.2 Diff URL:
https://github.com/ankitagarwal/moodle/compare/MOODLE_22_STABLE...MDL-28283-m22
Pull Master Branch:
~~MDL-28283~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/MDL-28283-master

Description

Not sure if this is a bug or intended behaviour, if it's not a bug please refile this in the correct spot.

I am using completion tracking on my Moodle site. For one of the courses I need to mark all students as complete once a certain date in 2012 has passed. However, the Date section of the Completion Tracking page only allows me to select dates between 2000 and 2010.

Here are the steps to reproduce the problem:

1. Enable completion tracking for the site (under Site Administration -> Course Default Settings)
2. Create a new course and enable completion tracking for that course (under Course Administration -> Edit Settings)

Creating a new course isn't mandatory, however the issue may be easier to test using a course with no students
3. Go to Course Administration -> Completion Tracking
4. Scroll down to the section labelled 'Date'
5. Click on the dropdown box labelled 'Year'

What was observed:

A dropdown box appeared with a range of years spanning 2000 - 2010.

What was expected:

A dropdown box containing a range of years spanning from a fixed year in the past (ie 1970) to a fixed year in the future (ie 2020).
or
A dropdown box containing a range of years relative to the current year (ie current year +/- 5 years).

This issue affects all versions of Moodle 2.0 and 2.1.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

completion_date.patch

11/Jul/11 12:47 PM

1 kB

Anita Viglione

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Michael de Raadt added a comment - 12/Jul/11 9:22 AM

Thanks for reporting this and providing a solution.

We need a policy on a relative range of years. I'm not sure if we have this.

Show

Michael de Raadt added a comment - 12/Jul/11 9:22 AM Thanks for reporting this and providing a solution. We need a policy on a relative range of years. I'm not sure if we have this.

Hide

Permalink

Ankit Agarwal added a comment - 03/Feb/12 5:03 PM

Should cleanly chery-pick to stables. Will upload other branches after the review.
Thanks

Show

Ankit Agarwal added a comment - 03/Feb/12 5:03 PM Should cleanly chery-pick to stables. Will upload other branches after the review. Thanks

Hide

Permalink

Ankit Agarwal added a comment - 03/Feb/12 5:07 PM

sorry for the spam.
Fixed the typo in githuburl

Show

Ankit Agarwal added a comment - 03/Feb/12 5:07 PM sorry for the spam. Fixed the typo in githuburl

Hide

Permalink

Rajesh Taneja added a comment - 07/Feb/12 1:29 PM

Patch looks Great, Anita and Ankit.

Please update test instructions, before pushing it for integration review

Show

Rajesh Taneja added a comment - 07/Feb/12 1:29 PM Patch looks Great, Anita and Ankit. Please update test instructions, before pushing it for integration review

Hide

Permalink

Ankit Agarwal added a comment - 13/Feb/12 11:42 AM

Thanks Raj for the review.
Up for integration!

Show

Ankit Agarwal added a comment - 13/Feb/12 11:42 AM Thanks Raj for the review. Up for integration!

Hide

Permalink

Sam Hemelryk added a comment - 14/Feb/12 9:00 AM

Thanks Ankit this has been integrated now

Show

Sam Hemelryk added a comment - 14/Feb/12 9:00 AM Thanks Ankit this has been integrated now

Hide

Permalink

Andrew Davis added a comment - 15/Feb/12 10:48 AM

Works as described. Passing.

Show

Andrew Davis added a comment - 15/Feb/12 10:48 AM Works as described. Passing.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM

It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

Closing as fixed, heading to zzzZZZzzz, niao

Show

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

People

Assignee:

Ankit Agarwal

Reporter:

Anita Viglione

Peer reviewer:

Rajesh Taneja

Integrator:

Sam Hemelryk

Tester:

Andrew Davis

Participants:

Andrew Davis, Anita Viglione, Ankit Agarwal, Eloy Lafuente (stronk7), Michael de Raadt, Rajesh Taneja, Sam Hemelryk

Vote (8)

Watch (7)

Dates

Created:

11/Jul/11 12:47 PM

Updated:

27/Feb/12 6:02 AM

Resolved:

17/Feb/12 10:07 AM

Integration date:

17/Feb/12