Moodle

cmi.scaled_passing_score not passed correctly

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: SCORM
  • Testing Instructions:
    Hide

    This is a pain to test - it must be done on a windows machine using the 2004 test harness. thanks to Mayank we should have a new automated Test harness that allows testing a bit easier very soon...

    but if you really want to test this despite the fact it's only going in head....

    download the CM-01 Test Package and ADL 2004 Test Suite
    run through the test and make sure this doesn't appear in the logs:
    ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""

    NOTE: there are still a range of other items causing the CM-01 to Fail - please see MDL-28740 for further detail.

    Show
    This is a pain to test - it must be done on a windows machine using the 2004 test harness. thanks to Mayank we should have a new automated Test harness that allows testing a bit easier very soon... but if you really want to test this despite the fact it's only going in head.... download the CM-01 Test Package and ADL 2004 Test Suite run through the test and make sure this doesn't appear in the logs: ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: "" NOTE: there are still a range of other items causing the CM-01 to Fail - please see MDL-28740 for further detail.
  • Affected Branches:
    MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    master_MDL-28541
  • Pull Master Diff URL:

Description

The ADL SCORM 2004 CM-01 test failed for a range of issues including:

  • cmi.scaled_passing_score - In activity 2 the GetValue("cmi.scaled_passing_score") returned null, expected - 0.8

If you want to execute test CM-01 you can download the CM-01 Test Package and ADL 2004 Test Suite

=====DETAILED LOG======
Start ADL LMS Test Content Package CM-01
Testing Activity 1
Activity 1 was launched as expected
ERROR: Did the LMS provide a disabled UI device that corresponds to the Continue Navigation Event? - Expected: Yes - Answered: No
ERROR: Did the LMS provide an enabled Table Of Contents that includes Activity 2 as selectable? - Expected: No - Answered: Yes
Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
ERROR: Evaluating GetValue("cmi.max_time_allowed") - Expected: "P5Y6M4DT12H30M58S" - LMS Returned: ""
ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
Testing Activity 2
Activity 2 was launched as expected
Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""
ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
Testing Activity 3
ERROR: Expected Activity 3 - LMS Launched Activity 2

Issue Links

This issue blocks:
MDL-28933 inconsistent checking of SCORM version Minor Closed
This issue will help resolve:
MDL-28740 ADL TEST: CM-01 Minor Open
This issue has been marked as being related by:
MDL-10707 SCORM 2004 - cmi.max_time_allowed mapping incorrect Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mayank Gupta added a comment - - edited

[1] is a patch that fixes cmi.max_time_allowed - changing from $userdata->maxtimeallowed to $userdadta->attemptAbsoluteDurationLimit.
This should fix - MDL-10707 as well.

[1] - https://github.com/mayankgupta/moodle/commit/6a2b3cb

I will be happy to modify it, if required.

Thanks,
Mayank.

Show
Mayank Gupta added a comment - - edited [1] is a patch that fixes cmi.max_time_allowed - changing from $userdata->maxtimeallowed to $userdadta->attemptAbsoluteDurationLimit. This should fix - MDL-10707 as well. [1] - https://github.com/mayankgupta/moodle/commit/6a2b3cb I will be happy to modify it, if required. Thanks, Mayank.
Hide
Permalink
Dan Marsden added a comment -

Hi Mayank - how are you going with the fix for cmi.scaled_passing_sco ?

thanks,

Dan

Show
Dan Marsden added a comment - Hi Mayank - how are you going with the fix for cmi.scaled_passing_sco ? thanks, Dan
Hide
Permalink
Mayank Gupta added a comment -

Hi Dan - I have added the code in mod/scorm/api.php to fetch the value of minnormalizedmeasure from the database table - scorm_seq_objective.
Did not commit it, as thought of committing the fix for Activity 3 with this one.

The patch [1] should fix cmi.scaled_passing_score

[1] - https://github.com/mayankgupta/moodle/commit/2313993232a543802f534aed06d9d25a1e5e8384

Thanks,
Mayank

Show
Mayank Gupta added a comment - Hi Dan - I have added the code in mod/scorm/api.php to fetch the value of minnormalizedmeasure from the database table - scorm_seq_objective. Did not commit it, as thought of committing the fix for Activity 3 with this one. The patch [1] should fix cmi.scaled_passing_score [1] - https://github.com/mayankgupta/moodle/commit/2313993232a543802f534aed06d9d25a1e5e8384 Thanks, Mayank
Hide
Permalink
Dan Marsden added a comment -

converting this bug to track only the patch for cmi.scaled_passing_score to get this patch in - all other CM-01 failures should be tracked on MDL-28740 - thanks!

Show
Dan Marsden added a comment - converting this bug to track only the patch for cmi.scaled_passing_score to get this patch in - all other CM-01 failures should be tracked on MDL-28740 - thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Passing this based in comments from Dan about it:

[22:01:25] <dan.marsden> cool - I would pass MDL-28541 without bothering to test too much - it only affects SCORM 2004 (which we don't officially support anyway) and it's only going in master...and it only adds an extra param to be available to the scorm 2004 api. (as long as it meets coding guidelines etc)

Show
Eloy Lafuente (stronk7) added a comment - Passing this based in comments from Dan about it: [22:01:25] <dan.marsden> cool - I would pass MDL-28541 without bothering to test too much - it only affects SCORM 2004 (which we don't officially support anyway) and it's only going in master...and it only adds an extra param to be available to the scorm 2004 api. (as long as it meets coding guidelines etc)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing, this is now part of Moodle. Big thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing, this is now part of Moodle. Big thanks!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
    Integration date:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.