Moodle

advcheckboxes toggle their value every form submit in the presence of a checkbox_controller

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.4, 2.1.1, 2.2
  • Fix Version/s: 2.0.5, 2.1.2
  • Component/s: Forms Library
  • Labels:

Description

Try the attached file. Keep clicking the button and see the checkbox state toggle.

Issue Links

This issue has a non-specific relationship to:
MDL-28972 html_quickform_toggle_checkboxes use getElementsByClassName which is not supported by ie Major Closed
MDL-31467 Select All Checkboxes does not work in IE8 Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

I don't get why the change does that but... testing will reveal if really works, lol. Integrated!

Show
Eloy Lafuente (stronk7) added a comment - I don't get why the change does that but... testing will reveal if really works, lol. Integrated!
Hide
Permalink
Rajesh Taneja added a comment -

Works Great on FF, chrome and Opera.
On ie8 state of checkbox doesn't change (Hence passing), but get JS error when click on "select all/none"

Message: Object doesn't support this property or method
Line: 14
Char: 5
Code: 0
URI: http://rajesh.moodle.local/moodle/test.php

As ie doesn't support getElementsByClassName, it will be nice to open a bug to fix this for ie. Probably change the function to use YUI

Show
Rajesh Taneja added a comment - Works Great on FF, chrome and Opera. On ie8 state of checkbox doesn't change (Hence passing), but get JS error when click on "select all/none" 
Message: Object doesn't support this property or method
Line: 14
Char: 5
Code: 0
URI: http://rajesh.moodle.local/moodle/test.php
As ie doesn't support getElementsByClassName, it will be nice to open a bug to fix this for ie. Probably change the function to use YUI
Hide
Permalink
Tim Hunt added a comment -

Oh drat! and I did change that line of code. I made the change because I was getting errors in Firefox. Please open a bug for the new IE issue.

Show
Tim Hunt added a comment - Oh drat! and I did change that line of code. I made the change because I was getting errors in Firefox. Please open a bug for the new IE issue.
Hide
Permalink
Rajesh Taneja added a comment -

Done Tim
MDL-28972

Show
Rajesh Taneja added a comment - Done Tim MDL-28972
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

Show
Eloy Lafuente (stronk7) added a comment - This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!
Hide
Permalink
Albert Gasset added a comment - - edited

This bug also affects Moodle 1.9.13+.

Show
Albert Gasset added a comment - - edited This bug also affects Moodle 1.9.13+.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
    Integration date:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.