Moodle

Categories and course titles ignored by Multilang filter

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7.1, 1.8
  • Fix Version/s: 1.8
  • Component/s: Filters
  • Labels:
    None

Description

When using <lang> tags in course categories and course titles, they are not filtered by the multilang filter.

I tried to set $CFG->filterall = true; in config.php and turning on Filter all string, the problem persist.

Issue Links

Activity

Hide
Martin Dougiamas added a comment -

From Eloy Lafuente (stronk7 at moodle.org) Monday, 9 May 2005, 11:52 PM:

Yeah, I know!

The problem was that, after testing it, the number of changes required to make course names multilang is really big (hundreds).

I'll retake it after finishing other prioritised tasks (at least, for the global community)

For a complete list about the multilang degree of implementation, you can take a look to:

http://moodle.org/mod/wiki/view.php?id=2935&page=CFGFilterAllSupport

(I try to maintain it updated)

Ciao

From Robert (rjb at robelko.com) Tuesday, 31 May 2005, 09:47 PM:

IMHO, multilang filter should be used for inline translation but not for wholesale multilingual course setup. I think that courses and activities should use a model parallel to language packs for full multilingual implementations. May be each language should have a setting [monolingual/multilingual] which would trigger using private language files.

Even some of the moodle pages itself would benefit. For example, I am providing custom instructions for login (using pop3 authentication). The text box for entering/editing it is kinda small for one language and becomes quite messy if I enter it in several languages. If would be simpler if I could say use such-and-such string from language pack and define these using language editing interface for any language I wish.

From Eloy Lafuente (stronk7 at moodle.org) Wednesday, 6 July 2005, 08:25 PM:

Uhm,

I agree that the multilang filter isn't the correct solution for all the situations. The DB approach sounds really nice (although it'll imply a huge modification of current code at 'introduction' level to support it).

Anyway, in the long term, it could be implemented because it provides some interesting features, sure (perhaps we could add this as a MUST feature for the 'everything-is-a-post' implementation when such work was started?).

Show
Martin Dougiamas added a comment - From Eloy Lafuente (stronk7 at moodle.org) Monday, 9 May 2005, 11:52 PM: Yeah, I know! The problem was that, after testing it, the number of changes required to make course names multilang is really big (hundreds). I'll retake it after finishing other prioritised tasks (at least, for the global community) For a complete list about the multilang degree of implementation, you can take a look to: http://moodle.org/mod/wiki/view.php?id=2935&page=CFGFilterAllSupport (I try to maintain it updated) Ciao From Robert (rjb at robelko.com) Tuesday, 31 May 2005, 09:47 PM: IMHO, multilang filter should be used for inline translation but not for wholesale multilingual course setup. I think that courses and activities should use a model parallel to language packs for full multilingual implementations. May be each language should have a setting [monolingual/multilingual] which would trigger using private language files. Even some of the moodle pages itself would benefit. For example, I am providing custom instructions for login (using pop3 authentication). The text box for entering/editing it is kinda small for one language and becomes quite messy if I enter it in several languages. If would be simpler if I could say use such-and-such string from language pack and define these using language editing interface for any language I wish. From Eloy Lafuente (stronk7 at moodle.org) Wednesday, 6 July 2005, 08:25 PM: Uhm, I agree that the multilang filter isn't the correct solution for all the situations. The DB approach sounds really nice (although it'll imply a huge modification of current code at 'introduction' level to support it). Anyway, in the long term, it could be implemented because it provides some interesting features, sure (perhaps we could add this as a MUST feature for the 'everything-is-a-post' implementation when such work was started?).
Hide
Nicolas Martignoni added a comment -

Does someone still work on this?

Show
Nicolas Martignoni added a comment - Does someone still work on this?
Hide
Eloy Lafuente (stronk7) added a comment -

This old request is being fixed by Nicolas... assigning to him. B-)

Show
Eloy Lafuente (stronk7) added a comment - This old request is being fixed by Nicolas... assigning to him. B-)
Hide
Nicolas Connault added a comment -

Fixed in 1.8, very extensive and touchy work to do on 1.7 to backport this.

Show
Nicolas Connault added a comment - Fixed in 1.8, very extensive and touchy work to do on 1.7 to backport this.
Hide
Eloy Lafuente (stronk7) added a comment -

Cool!

Finally, It'd be perfect to keep http://docs.moodle.org/en/Development:Filterall_support synchronised!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Cool! Finally, It'd be perfect to keep http://docs.moodle.org/en/Development:Filterall_support synchronised! Ciao
Hide
Nicolas Martignoni added a comment -

Can't see any change in my fresh 1.8b Is this really in CVS now?

Show
Nicolas Martignoni added a comment - Can't see any change in my fresh 1.8b Is this really in CVS now?
Hide
Robert Brenstein added a comment -

I think support from 1.8 on suffice. I believe that 1.7 will be quite quickly abandonden in favor of 1.8. IF retrofitting, 1.6 would probably make more sense. My feeling is that more people will stay with it for one or the other reason. Too bad we don't have a realistic assessment of the relative active usage of different versions (cf. MDL-7359)

Show
Robert Brenstein added a comment - I think support from 1.8 on suffice. I believe that 1.7 will be quite quickly abandonden in favor of 1.8. IF retrofitting, 1.6 would probably make more sense. My feeling is that more people will stay with it for one or the other reason. Too bad we don't have a realistic assessment of the relative active usage of different versions (cf. MDL-7359)
Hide
Nicolas Martignoni added a comment -

Reopening, as I don't see any difference.

Is this really in CVS (branch MOODLE_18_STABLE) ?

Show
Nicolas Martignoni added a comment - Reopening, as I don't see any difference. Is this really in CVS (branch MOODLE_18_STABLE) ?
Hide
Nicolas Connault added a comment -

Just be mindful that due to http://tracker.moodle.org/browse/MDL-8955 , the way you write your multilang strings could lead to silent failure. Until this other bug is fixed, this will continue to be an issue.

Show
Nicolas Connault added a comment - Just be mindful that due to http://tracker.moodle.org/browse/MDL-8955 , the way you write your multilang strings could lead to silent failure. Until this other bug is fixed, this will continue to be an issue.
Hide
Nicolas Connault added a comment -

Multilang strings work fine for Site, Category and Course titles (fullname and shortname), however until MDL-8955 is resolved any variation from the order of attributes (or even the introduction of extra spaces in the span tags) will cause the filter to fail silently.

Show
Nicolas Connault added a comment - Multilang strings work fine for Site, Category and Course titles (fullname and shortname), however until MDL-8955 is resolved any variation from the order of attributes (or even the introduction of extra spaces in the span tags) will cause the filter to fail silently.
Hide
Nicolas Martignoni added a comment -

Yes Nicolas C, you're right, it works correctly (except MDL-8955 issue). I think we can close this.

However, I just noticed that multilang filter doesn't work on role titles in the Gradebook admin page (though it works in other places, like role definitions). Should I open another bug for this?

Show
Nicolas Martignoni added a comment - Yes Nicolas C, you're right, it works correctly (except MDL-8955 issue). I think we can close this. However, I just noticed that multilang filter doesn't work on role titles in the Gradebook admin page (though it works in other places, like role definitions). Should I open another bug for this?
Hide
Nicolas Connault added a comment -

All fixed for now.

Show
Nicolas Connault added a comment - All fixed for now.
Hide
Nicolas Martignoni added a comment -

Verified, closing. Thank you for the fix.

Show
Nicolas Martignoni added a comment - Verified, closing. Thank you for the fix.
Hide
Andras Muranyi added a comment -

Sorry but I have to say multilang still does not work for categories in my 1.8 (with filterall on).

Show
Andras Muranyi added a comment - Sorry but I have to say multilang still does not work for categories in my 1.8 (with filterall on).
Hide
Nicolas Martignoni added a comment -

Confirming Andras observation, but not on 1.8. The issue is present in 1.8.2+.

Andras, I opened bug MDL-11608 for this issue.

Show
Nicolas Martignoni added a comment - Confirming Andras observation, but not on 1.8. The issue is present in 1.8.2+. Andras, I opened bug MDL-11608 for this issue.

Dates

  • Created:
    Updated:
    Resolved: