[#MDL-30723] Typos in English - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.1
Fix Version/s: 2.1.5, 2.2.2
Component/s: Language
Labels:
- patch
- triaged

Testing Instructions:
Hide

run the following command on each patched branch and make sure there is no output:

cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin

note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.
Show
run the following command on each patched branch and make sure there is no output:

cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin

note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.
Difficulty:
Easy
Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/gerrywastaken/moodle.git
Pull 2.1 Branch:
21_~~MDL-30723~~_fixing_several_english_typos
Pull 2.1 Diff URL:
https://github.com/gerrywastaken/moodle/compare/MOODLE_21_STABLE...21_MDL-30723_fixing_several_english_typos
Pull 2.2 Branch:
22_~~MDL-30723~~_fixing_several_english_typos
Pull 2.2 Diff URL:
https://github.com/gerrywastaken/moodle/compare/MOODLE_22_STABLE...22_MDL-30723_fixing_several_english_typos
Pull Master Branch:
m_~~MDL-30723~~_fixing_several_english_typos
Pull Master Diff URL:
https://github.com/gerrywastaken/moodle/compare/master...m_MDL-30723_fixing_several_english_typos

Description

[err_networkingoff_help,portfolio_mahara] "pugin" => "plugin".
[tiierror1024,plagiarism_turnitin] "legitamate" => "legitimate".
[configlockframe,hotpot] "navagation" => "navigation"

Issue Links

This issue has a non-specific relationship to:
CONTRIB-3457	English typos in hotpot

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Michael de Raadt added a comment - 14/Dec/11 11:21 AM

Thanks for reporting that.

Koen, do you think you could make these amendments?

Show

Michael de Raadt added a comment - 14/Dec/11 11:21 AM Thanks for reporting that. Koen, do you think you could make these amendments?

Hide

Permalink

Helen Foster added a comment - 15/Dec/11 9:50 PM

Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings.

As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.

Show

Helen Foster added a comment - 15/Dec/11 9:50 PM Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings. As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.

Hide

Permalink

Gerard Caulfield added a comment - 10/Feb/12 1:42 AM

[printintroexplain,mod_resource] "bellow" => "below" is fixed by ~~MDL-29153~~ so I'm amending this description

Show

Gerard Caulfield added a comment - 10/Feb/12 1:42 AM [printintroexplain,mod_resource] "bellow" => "below" is fixed by ~~MDL-29153~~ so I'm amending this description

Hide

Permalink

Gerard Caulfield added a comment - 10/Feb/12 1:57 AM

I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?

Show

Gerard Caulfield added a comment - 10/Feb/12 1:57 AM I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?

Hide

Permalink

David Mudrak added a comment - 10/Feb/12 6:08 AM

As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.

Show

David Mudrak added a comment - 10/Feb/12 6:08 AM As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.

Hide

Permalink

Gerard Caulfield added a comment - 10/Feb/12 8:03 AM

I see, thanks again David. I'll do so.

Show

Gerard Caulfield added a comment - 10/Feb/12 8:03 AM I see, thanks again David. I'll do so.

Hide

Permalink

Gerard Caulfield added a comment - 10/Feb/12 8:13 AM

Issue added to contrib.

Show

Gerard Caulfield added a comment - 10/Feb/12 8:13 AM Issue added to contrib.

Hide

Permalink

Ankit Agarwal added a comment - 10/Feb/12 1:19 PM

Hi Gerry,
This looks great.
+1 to integrate.
Don't forget to update testing instructions
Thanks

Show

Ankit Agarwal added a comment - 10/Feb/12 1:19 PM Hi Gerry, This looks great. +1 to integrate. Don't forget to update testing instructions Thanks

Hide

Permalink

Gerard Caulfield added a comment - 10/Feb/12 1:37 PM

Thanks Ankit, I'll make sure to add the instructions

Show

Gerard Caulfield added a comment - 10/Feb/12 1:37 PM Thanks Ankit, I'll make sure to add the instructions

Hide

Permalink

Helen Foster added a comment - 10/Feb/12 4:07 PM

Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?

Show

Helen Foster added a comment - 10/Feb/12 4:07 PM Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?

Hide

Permalink

Gerard Caulfield added a comment - 11/Feb/12 2:50 PM

Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.

Show

Gerard Caulfield added a comment - 11/Feb/12 2:50 PM Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.

Hide

Permalink

Sam Hemelryk added a comment - 13/Feb/12 1:01 PM

Thanks Gerry, this has been integrated now

Show

Sam Hemelryk added a comment - 13/Feb/12 1:01 PM Thanks Gerry, this has been integrated now

Hide

Permalink

Glenn Ansley added a comment - 14/Feb/12 6:01 AM

Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.

Show

Glenn Ansley added a comment - 14/Feb/12 6:01 AM Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.

Hide

Permalink

Gerard Caulfield added a comment - 14/Feb/12 6:07 AM

Thanks Sam, Glenn and everybody else.

Show

Gerard Caulfield added a comment - 14/Feb/12 6:07 AM Thanks Sam, Glenn and everybody else.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM

It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

Closing as fixed, heading to zzzZZZzzz, niao

Show

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

People

Assignee:

Gerard Caulfield

Reporter:

Erkki Laaneoks

Peer reviewer:

Ankit Agarwal

Integrator:

Sam Hemelryk

Tester:

Glenn Ansley

Participants:

Ankit Agarwal, David Mudrak, Eloy Lafuente (stronk7), Erkki Laaneoks, Gerard Caulfield, Glenn Ansley, Helen Foster, Michael de Raadt, Sam Hemelryk

Vote (0)

Watch (1)

Dates

Created:

14/Dec/11 7:27 AM

Updated:

27/Feb/12 6:02 AM

Resolved:

17/Feb/12 10:07 AM

Integration date:

17/Feb/12