Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Duplicate
-
Affects Version/s: 1.5
-
Fix Version/s: None
-
Component/s: Administration
-
Labels:None
-
Environment:All
-
Affected Branches:MOODLE_15_STABLE
Description
The function in moodle to geolocate an ip addres uses ipatlas. On it's homepage, they let the user know that this databse is not maintained anymore. A lot of the ip's result in an inaccurate or wrong response.
This can be remedied easily by using another provider for the geolocation.
Just linking to a file containing this code:
<OBJECT DATA='http://www.hostip.info/map/frame.html'
TYPE='text/html' BORDER=0
WIDTH=610 HEIGHT=330 HSPACE=0 VSPACE=0>
</OBJECT>
should be enough to get more accurate results. It still remains a single point of failure, though you can download the ip-location database and sourcecode and offer the service yourself (you will need to add a box with the geolocation info somewhere on the frontpage so users will update your db).
If anyone cares I will write this fix myself...
Issue Links
| This issue duplicates: | ||||
| MDL-6246 | replace ip lookup with something better |
|
|
|
From Martin Dougiamas (martin at moodle.com) Monday, 9 May 2005, 07:46 PM:
Yes, the data ipatlas uses is out of date.
We did a survey/trial of hostip in Using Moodle last year and the result was that it hardly worked for anyone, but it may have improved since then.
If you want to implement this in some way so that Moodle script like lib/locateip.php is called, and that Moodle script calls or forwards the IP as part of a URL to an admin-configurable provider, that would be great.
From Jelle Boomstra (jelle.bugzilla.moodle at nietsch.dds.nl) Monday, 9 May 2005, 08:20 PM:
let's not rush things with selectable service providers, shall we?
A simple locateip.php that uses hostip.info only should be easy to do.
Maybe you can explain how something that is admin-selectable should be done?
As for completeness: hostip is a community effort, so you rely on the information that your users provide. Maybe an automated submit to hostip, based on the location as entered into moodle could be used? But you will indeed never reach 100% accuracy, especially with dialup.
As for the current ipatlas: It places dutch users as located in Redmont, or all in Amsterdam, where the dutch internet exchange is located. It looks like the last data in ipatlas is from 2003, the biggest expansion of braodband (that can be mapped accurately) is after that time. So the current stuff is not very accurate anyway.
Maybe php has a reverse dns lookup? someuser.demon.nl is much more informative than 192.168.2.1.
But enough talk, Lets start coding (ehm, first cvs update and resolving non-existant conflicts...)
From Martin Dougiamas (martin at moodle.com) Monday, 9 May 2005, 08:50 PM:
Making it configurable is very easy.
Admin provides URL:
eg http://www.hostip.info/map/index.html?ip=
eg http://moodle.org/lib/ipatlas/plot.php?address=
Moodle adds IP to URL:
eg http://www.hostip.info/map/index.html?ip=203.59.156.114
eg http://moodle.org/lib/ipatlas/plot.php?address=203.59.156.114